-
Notifications
You must be signed in to change notification settings - Fork 816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[E2E] [OSX] Client not accepting e2e encryption passphrase #268
Comments
any idea @tcanabrava @dantti? thanks for the report @niwakame |
When I tested this using a second user unix account it worked fine, would need to test again... |
Just tested here and it worked fine, the last line
had the key contents where you see just \n. Now the obvious question, did you try with another client like Android? And are you sure the passphrase is right? |
Thanks for testing. The passphrase is definitely right. I will try with an Android device later on and see if this makes a difference. And try vice versa desktop and mobile. |
Is there a way to delete the keys on the server, so I can start the key creation procedure again? |
same here with 64cbc8 on macOS - same log output @niwakame . encryted folder was created by stock iOS app - E2E decryption was possible with prereleases/E2E/Windows/ c04d1f on windows10 |
hm...
when you get the payload from the server you are receiving an empty
metadata.
I'll try the following:
create an account in a linux box,
test the download in another linux box.
Expect test results and patches for today tomorrow.
…On Sat, Apr 28, 2018 at 4:56 PM, Christian Messerschmidt < ***@***.***> wrote:
same here with 64cbc8 on macOS - same log output @niwakame
<https://github.com/niwakame> . encryted folder was created by iOS - E2E
decryption was possible with prereleases/E2E/Windows/ on windows10
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#268 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AD1zUHqssIJuYfz2pH6JFfZeC2yElzMFks5ttIMdgaJpZM4TqcsZ>
.
|
Confirming @messimuc 's observations. It's fully working with iOS and Windows, yet OSX is failing. |
hm, please, now I'm confused. it's working or not with this client, in Windows? |
Any updates / roadmap? |
Mmm it sounds like the IOS code does something slightly different from our code. I would need some way to verify this. |
I can try to reproduce this error. |
Just bumped into it 😭 |
Status yet: 😭 At first I got the same problem described in the issue and the client would not accept the passphrase. I debugged and found out that _privateKey is null 💀 here: desktop/src/libsync/clientsideencryption.cpp Lines 1027 to 1028 in ac631d0
So I have found this:
After trying to compile Qt 5.11.1 with openssl enabled instead of not accepting the mnemonic, it crashes 😞 when you click ok on the dialog when the mnemonic is displayed for the first time for the user. It crashes 💣 here - pkey is 0x0: desktop/src/libsync/clientsideencryption.cpp Line 397 in ac631d0
Any ideas @tcanabrava @dantti @rullzer? I didn't try yet to use any other format for the key, is that even recommendable? Or the whole issue doesn't make any sense :D (sanity check)? Maybe I am missing pieces of the end to end encryption workflow? |
Changing the format of the key is not "allowed" as it needs to stay this way as Android/iOS already using it and write their keys into this format. Shall I give you a "working" key from Android to debug? And you can give me the non-working one, so I can try to find the problem via debugging it on Android side. |
I thought so.
Yes, that sounds like a good idea. Thanks! |
private key:
encrypted:
decrypted:
key: |
If you have any further questions, do not hesitate to ping me on IRC :-) |
Removes QSslkey. See #268 Signed-off-by: Camila San <[email protected]>
Possible fix: #727 |
Confirm fixed in 2.5 Release, thank you @camilasan ! |
I created an encrypted folder with the iOS client, compiled the latest master ( 64cbc88 ) on OSX. When starting the client, it asks me for the E2E passphrase, but it's not accepting the input as correct.
Log output:
And then the popup appears again. Any pointers?
The text was updated successfully, but these errors were encountered: