Fix some small accessibility issues #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tobia De Koninck <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #597 +/- ##
=======================================
Coverage 75.46% 75.46%
=======================================
Files 52 52
Lines 1969 1969
=======================================
Hits 1486 1486
Misses 483 483 |
juliusknorr
approved these changes
Aug 26, 2018
|
Awesome. 🎉 Thank you very much for looking into that @LEDfan |
|
Can you open an issue for the remaining tasks? |
|
Yup, here it is #598 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed some small accessibility issues fund during the workshop at the Nextcloud conf 👍 using the aXe browser extension.
TODO
There are still some harder issues left:
(The first one is a false-positive due to
ng-if).Checklist