Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable27] fix(CardMenu): introduce cardRichObject in CardMenu #5610

Merged
merged 1 commit into from
Feb 20, 2024
Merged

[stable27] fix(CardMenu): introduce cardRichObject in CardMenu #5610

merged 1 commit into from
Feb 20, 2024

Conversation

Antreesy
Copy link

  • Resolves: regression from backport [stable27] Issue triage fix collection #5286
  • As I see, backport wasn't complete, and CardMenuEntries component is missing at stable27
    • CardMenu doesn't have cardRichObject computed in any form
    • external plugin click results in undefined:
      image

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

@Antreesy Antreesy added this to the 1.10.0 (Nextcloud 27) milestone Feb 20, 2024
@Antreesy Antreesy self-assigned this Feb 20, 2024
@cypress Cypress
Copy link

cypress bot commented Feb 20, 2024

Passing run #1801 ↗︎

0 17 0 0 Flakiness 0

Details:

Merge 10a3060 into 0542900...
Project: Deck Commit: cc6309b47b ℹ️
Status: Passed Duration: 02:17 💡
Started: Feb 20, 2024 2:36 PM Ended: Feb 20, 2024 2:38 PM

Review all test suite changes for PR #5610 ↗︎

@Antreesy Antreesy mentioned this pull request Feb 20, 2024
Merged
@juliusknorr juliusknorr merged commit 69ff345 into stable27 Feb 20, 2024
14 checks passed
@juliusknorr juliusknorr deleted the fix/5286/stable27-talk-plugin branch February 20, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@mejo- mejo- Awaiting requested review from mejo-

@luka-nextcloud luka-nextcloud Awaiting requested review from luka-nextcloud

Assignees

@Antreesy Antreesy

Labels
3. to review bug frontend
Projects
None yet
Milestone
1.10.0 (Nextcloud 27)
Development

Successfully merging this pull request may close these issues.
2 participants
@Antreesy @juliusknorr