Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REST API #535

Merged
merged 78 commits into from
Aug 15, 2018
Merged
Changes from 1 commit
Commits
Show all changes
78 commits
Select commit Hold shift + click to select a range
0c266d4
List boards, and fetch a specific board.
srbaker Jul 28, 2017
7dcd49c
Delete boards via the API.
srbaker Jul 29, 2017
b4224da
Undo deletion of boards via API.
srbaker Jul 29, 2017
975b6f3
Update the documentation.
srbaker Jul 29, 2017
84a8db7
Change the API version to 1.0, and fix the preflighted_cors version.
srbaker Jul 29, 2017
86dde2d
These parens are not needed.
srbaker Jul 29, 2017
8316a0b
Board creation via API.
srbaker Jul 29, 2017
a4b3484
Add Stack support to API.
srbaker Jul 29, 2017
40f34eb
Fix the routing and the stacks API endpoint.
srbaker Jul 29, 2017
8ec9703
Re-format code according to the coding style.
srbaker Feb 12, 2018
41cf623
This should be 200 on deletion, so we can tell whether a deletion suc…
srbaker Feb 12, 2018
1ffa321
Extract getBoardPererequisites() so it can be re-used.
srbaker Feb 12, 2018
e32adb1
Don't need to pass around the userInfo with it encapsulated in BoardS…
srbaker Feb 12, 2018
9fc01eb
Move DI of IUserManager, IGroupManager, userId to the BoardService
juliusknorr Jul 12, 2018
656e8ef
quick test in StackApiController
Jul 12, 2018
8771e35
Added exception handling to StackApiController->create()
Jul 12, 2018
9bc9569
Added checks to see if the entity is not found in BoardApiController …
Jul 12, 2018
3b49c7f
Added exception handling to BoardApiController -> Delete
Jul 12, 2018
d82746b
Error handling for undoDelete and created an update method in BoardAp…
Jul 12, 2018
6822d7d
Error handling in undelete function and created the update function i…
Jul 12, 2018
0da84a3
Corrected comment in BoardApiController from copy / paste.
Jul 13, 2018
cec0649
Error handling for StackApiController->Index()
Jul 13, 2018
be91ff6
StackApiController added the update put route.
Jul 13, 2018
03e0559
StackApiController->delete($boardId, $id) added in error handling
Jul 13, 2018
3cb496d
Cleaned up StackApiController to use proper route parameters, removed…
Jul 13, 2018
5415ec2
Validation Checking against StackApiController
Jul 13, 2018
ced87ed
Put in validation responses in BoardApiController
Jul 13, 2018
0c0910e
Co authored for my changes.
Jul 13, 2018
a68e888
Started CardApiController
Jul 13, 2018
e5f7f89
Wrote update method for CardApiController
Jul 13, 2018
b82591a
Added delete operation to CardApiController
Jul 13, 2018
7e4d242
Updated the CardApiController->update method to allow updating of arc…
Jul 13, 2018
6002067
Created LabelApiController and it's get / update methods.
Jul 13, 2018
f97c7c3
Added in Create + Delete functions to the LabelApiController
Jul 13, 2018
7d9fc83
Code style fixings.
Jul 13, 2018
a14ca3d
Better error handling in StackApiController
Jul 13, 2018
d9f3d49
Better variable name for stackService in StackApiController
Jul 13, 2018
a388d19
Refactored error handling in StackApiController and moved it into Api…
Jul 13, 2018
2668f6b
committing WIP (improving error validation across the api's)
Jul 13, 2018
dd1d424
Finished Error handling across the API
Jul 13, 2018
cfd9ab9
Implemented StackApiController Get Function.
Jul 13, 2018
881b05a
fixed BoardControllerTest from errors
Jul 14, 2018
e0049cf
Resolved unit tests errors, down from 36 to 9.
Jul 14, 2018
e8c53d7
fixed more unit tests.
Jul 14, 2018
fad579c
Wrote first unit test for BoardApiController
Jul 14, 2018
bd254fd
BoardApiControllerTest wrote get() tests.
Jul 15, 2018
1fe7056
Wrote unit tests for the BoardApiController -> create tests
Jul 15, 2018
8dd7326
BoardApiController wrote update tests
Jul 15, 2018
6d57b10
BoardApiControllerTest wrote delete tests
Jul 15, 2018
2482dc9
Fix BoardServiceTest
juliusknorr Jul 15, 2018
dcfb9f3
Properly annotate exceptions thrown by services
juliusknorr Jul 15, 2018
54f110f
first attempt at BoardApiControllerTest->testGetNoPermission()
Jul 15, 2018
891fa7b
Created index tests for StackApiTestController
Jul 15, 2018
5719e9f
Wrote unit tests against StackApiController -> get()
Jul 16, 2018
570ac81
added the create tests in StackApiControllerTest
Jul 16, 2018
8cac183
simple code style changes according to codacy standards.
Jul 16, 2018
d33dd3e
Moved BadRequestException checks to middleware, removed uneeded unit …
Jul 16, 2018
f2268c7
Moved Data Response checks into stack serivice, cleaned up related un…
Jul 16, 2018
f1169b9
finished writing StackApiControllerTest.php
Jul 16, 2018
5bc8a36
Split Card Update in CardApiController as it was gigantic and broke c…
Jul 16, 2018
9c81584
Wrote tests for CardApiControllerTest.php
Jul 16, 2018
184cd00
Wrote initial unit tests for LabelApiControllerTest.php
Jul 17, 2018
507a7fd
Code cleanup, removing unused code from older iteration.
Jul 17, 2018
72aeb72
fixed up missing checks from labelService, BadRequestException is now…
Jul 20, 2018
3e965d0
Implemented additional CardApiController endpoints
Jul 20, 2018
172a80f
Added additional endpoints for cards / stacks
Jul 21, 2018
e88c9a7
Wrote unit tests for AttachmentApiController and stubbed out Attachme…
Jul 23, 2018
37a2858
wrote attachment api controller, fixed bug caught by unit test in Car…
Jul 24, 2018
7930fec
Added in BadRequestException tests into AttachmentService.php
Aug 7, 2018
e857145
Added BadRequestException checks into BoardService.php
Aug 7, 2018
6f5c0a2
Added in BadRequestException checks in CardService.php
Aug 7, 2018
aba7d02
Added BadRequestException checks in DefaultBoardService. Fixed bug in…
Aug 7, 2018
4391bf4
added missing BadRequestException checks to StackService.php
Aug 7, 2018
47a7e76
Catch DoesNotExistException to return proper API repsonses
juliusknorr Aug 14, 2018
81d3332
Fix comparison
juliusknorr Aug 15, 2018
0c9b1f5
Mapper can be null if provided id is a board id
juliusknorr Aug 15, 2018
babfcbd
Fix imports
juliusknorr Aug 15, 2018
5639bd1
Fix controller deleted at parameter
juliusknorr Aug 15, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Code cleanup, removing unused code from older iteration.
Signed-off-by: Ryan Fletcher <[email protected]>
Ryan Fletcher authored and juliusknorr committed Aug 15, 2018
commit 507a7fd24351b391a9b73ac2f104d9a084a02079
9 changes: 3 additions & 6 deletions lib/Controller/CardApiController.php
Original file line number Diff line number Diff line change
@@ -27,8 +27,7 @@
use OCP\AppFramework\Http;
use OCP\AppFramework\Http\DataResponse;
use OCP\IRequest;

use OCA\Deck\Controller\Helper\ApiHelper;

use OCA\Deck\Service\BoardService;
use OCA\Deck\Service\StackService;
use OCA\Deck\Service\CardService;
@@ -39,15 +38,13 @@
* @package OCA\Deck\Controller
*/
class CardApiController extends ApiController {
private $cardService;
private $boardService;
private $stackService;
private $cardService;
private $userId;

/**
* @param string $appName
* @param IRequest $request
* @param CardService $service
* @param CardService $cardService
* @param $userId
*/
public function __construct($appName, IRequest $request, CardService $cardService, $userId) {
49 changes: 0 additions & 49 deletions lib/Controller/Helper/ApiHelper.php

This file was deleted.

2 changes: 1 addition & 1 deletion lib/Controller/LabelApiController.php
Original file line number Diff line number Diff line change
@@ -44,7 +44,7 @@ class LabelApiController extends ApiController {
/**
* @param string $appName
* @param IRequest $request
* @param LabelService $service
* @param LabelService $labelService
* @param $userId
*/
public function __construct($appName, IRequest $request, LabelService $labelService, $userId) {