Prevent tag itself being edit button if user lacks permissions #4574
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The tag itself is also a button for triggering edit mode. It should not be if user permissions don't permit editing. The current behavior lets the user attempt the edit (which then understandably fails - albeit without any feedback to the user since it was likely never expected to occur). This change prevents the button from being clickable to trigger edit mode unless the user has the correct permissions. Modeled after the adjacent checks that already exist which remove the edit and delete buttons for users with permissions. I believe this simply implements what was intended and the label/tag itself also being able to trigger editing was just a minor oversight.
TODO
Checklist