Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve search performance #3362

Merged
merged 3 commits into from
Oct 5, 2021
Merged

Improve search performance #3362

merged 3 commits into from
Oct 5, 2021

Conversation

julien-nc
Copy link
Member

  • Move some work from php to the database when searching for boards:
    • search query
    • cursor (max last modified date)
  • Avoid since in DB queries when not needed
  • Harmonize since and before filter parameters across services

@julien-nc julien-nc added enhancement 3. to review php Pull requests that update Php code feature: search labels Oct 4, 2021
@julien-nc julien-nc requested a review from juliusknorr October 4, 2021 16:37
juliusknorr
juliusknorr approved these changes Oct 5, 2021
View reviewed changes
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one 🚀

At some point we should really switch over to the query builder there, but lets move on with this 👍

@juliusknorr juliusknorr merged commit 86fd1fb into master Oct 5, 2021
@juliusknorr juliusknorr deleted the enh/improve-search-perf branch October 5, 2021 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

Assignees
No one assigned
Labels
3. to review enhancement feature: search php Pull requests that update Php code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julien-nc @juliusknorr