Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

card dashboard #1934

Merged
merged 13 commits into from
Aug 20, 2020
Merged

card dashboard #1934

merged 13 commits into from
Aug 20, 2020

Conversation

jakobroehrl
Copy link
Contributor

@jakobroehrl jakobroehrl commented May 20, 2020

@juliusknorr
Copy link
Member

Wouldn't it be better to return a special kind of board from the backend?

Not sure what you mean with that.

lib/Db/CardMapper.php Outdated Show resolved Hide resolved
src/store/main.js Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #1934 into master will decrease coverage by 0.11%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1934      +/-   ##
==========================================
- Coverage   56.92%   56.80%   -0.12%     
==========================================
  Files          77       77              
  Lines        3842     3850       +8     
==========================================
  Hits         2187     2187              
- Misses       1655     1663       +8     

@juliusknorr
Copy link
Member

juliusknorr commented Jun 18, 2020

As discussed, I don't see an easy way around fetching the users boards first as done here and then fetch the list of cards for the dashboards for each board.

Jakob: And we want to create a new Service called DashboardService.php

@jakobroehrl jakobroehrl force-pushed the enh/cardDashboard branch 2 times, most recently from d736555 to 8912179 Compare June 24, 2020 09:01
@jakobroehrl jakobroehrl force-pushed the enh/cardDashboard branch 5 times, most recently from 4d953ef to afd5396 Compare June 26, 2020 11:11
@jakobroehrl jakobroehrl force-pushed the enh/cardDashboard branch 2 times, most recently from 996daa5 to aad6102 Compare July 9, 2020 07:12
@jakobroehrl jakobroehrl force-pushed the enh/cardDashboard branch 2 times, most recently from ba41076 to 6c9bf5b Compare July 9, 2020 12:52
lib/Db/CardMapper.php Outdated Show resolved Hide resolved
appinfo/routes.php Outdated Show resolved Hide resolved
}
dataset.forEach(card => {

if (card.duedate === null) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be done in getters in the dashboard store

src/store/dashboard.js Outdated Show resolved Hide resolved
jakobroehrl and others added 11 commits August 20, 2020 11:40
Signed-off-by: Jakob Röhrl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Jakob Röhrl <[email protected]>
Signed-off-by: Jakob Röhrl <[email protected]>
Signed-off-by: Jakob Röhrl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this in as a first part for the my assigned cards overview and iterate over it in follow ups.

@juliusknorr juliusknorr merged commit 6699eb7 into master Aug 20, 2020
@juliusknorr juliusknorr deleted the enh/cardDashboard branch August 20, 2020 11:26
@juliusknorr juliusknorr mentioned this pull request Sep 1, 2020
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Open/Assigned Tasks in all board [$100]
3 participants