Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new filter: unassigned cards #1926

Merged
merged 2 commits into from
Jul 31, 2020
Merged

new filter: unassigned cards #1926

merged 2 commits into from
Jul 31, 2020

Conversation

jakobroehrl
Copy link
Contributor

Signed-off-by: Jakob Röhrl [email protected]

@codecov-commenter
Copy link

Codecov Report

Merging #1926 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1926   +/-   ##
=======================================
  Coverage   56.92%   56.92%           
=======================================
  Files          77       77           
  Lines        3842     3842           
=======================================
  Hits         2187     2187           
  Misses       1655     1655           

src/store/card.js Outdated Show resolved Hide resolved
Signed-off-by: Jakob Röhrl <[email protected]>
@jakobroehrl jakobroehrl force-pushed the enh/unassignedFilter branch from e2653c7 to de0145c Compare May 19, 2020 09:23
@jakobroehrl jakobroehrl requested a review from juliusknorr May 19, 2020 09:23
src/store/card.js Outdated Show resolved Hide resolved
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comment on the code, also it is possible to do the following:

  • Unassigned
  • User A

It should only be possible to select either unassigned or assigned users

Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline

@jakobroehrl
Copy link
Contributor Author

It's working, ready to merge

@juliusknorr juliusknorr merged commit 8defe83 into master Jul 31, 2020
@juliusknorr juliusknorr deleted the enh/unassignedFilter branch July 31, 2020 21:04
@juliusknorr juliusknorr mentioned this pull request Sep 1, 2020
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add to filter: unassigned cards
3 participants