Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comments reply #1537

Merged
merged 15 commits into from
Mar 10, 2020
Merged

Comments reply #1537

merged 15 commits into from
Mar 10, 2020

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Feb 11, 2020 •
edited
Loading

TODO

  • Frontend for selecting a comment to reply to
  • Backend to fetch nested comments (1 level depth)
  • Create endpoint to set parentId on comment
  • Move endpoints to OCS route
  • API documentation

@juliusknorr
Copy link
Member Author

@jancborchardt Could you have a look if you have some design feedback on this one? This is the current state:

image

@juliusknorr juliusknorr added this to the 🚀 Next major 1.0.0 milestone Mar 6, 2020
@juliusknorr juliusknorr requested a review from jakobroehrl March 6, 2020 16:44
@juliusknorr juliusknorr mentioned this pull request Mar 7, 2020
Merged
jakobroehrl
jakobroehrl approved these changes Mar 9, 2020
View reviewed changes
Copy link
Contributor

@jakobroehrl jakobroehrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@juliusknorr
WIP: Comment reply
07fd562 
Signed-off-by: Julius Härtl <[email protected]>
@juliusknorr
Properly handle spaces in user ids (fixes #1515)
e6de5fe 
Signed-off-by: Julius Härtl <[email protected]>
@juliusknorr
Implement api endpoints for comment reply handling
841fa0d 
Signed-off-by: Julius Härtl <[email protected]>
@juliusknorr
Use @nextcloud/router
cc4e544 
Signed-off-by: Julius Härtl <[email protected]>
@juliusknorr
Do not lint jsdocs for now
ef48636 
Signed-off-by: Julius Härtl <[email protected]>
@juliusknorr
Add fixme about ins/del
7ab2a83 
Signed-off-by: Julius Härtl <[email protected]>
@juliusknorr
Move to OCS routes for new comments api
fb06cac 
Signed-off-by: Julius Härtl <[email protected]>
@juliusknorr
Show relative timestamp using mixin
ecbbc29 
Signed-off-by: Julius Härtl <[email protected]>
@juliusknorr
Move to OCS requests in comments api service
694438b 
Signed-off-by: Julius Härtl <[email protected]>
@juliusknorr
Fix extracting the richtext element since there is no component ref a…
81e8100 
…vailable for functional components

Signed-off-by: Julius Härtl <[email protected]>
@juliusknorr
Cleanup
b7a870f 
Signed-off-by: Julius Härtl <[email protected]>
@juliusknorr
Fix reply styling
755f052 
Signed-off-by: Julius Härtl <[email protected]>
@juliusknorr
Add API docs for comments OCS API
3f891bf 
Signed-off-by: Julius Härtl <[email protected]>
@juliusknorr
Fix editing comments in the UI
0831040 
Signed-off-by: Julius Härtl <[email protected]>
@juliusknorr
Comments are available to all users of a board though webdav, but at …
7e4b42a 
…least check for read permission to the board

Signed-off-by: Julius Härtl <[email protected]>
@juliusknorr
Copy link
Member Author

Let's merge this so we can continue with the other pull requests that base on this.

@jancborchardt Your feedback would still be appreciated 😉

@juliusknorr juliusknorr merged commit 82f35bb into master Mar 10, 2020
@juliusknorr juliusknorr deleted the enh/comments-reply branch March 10, 2020 11:27
@sudwhiwdh
Copy link

It has already been merged and is still on the roadmap for 1.5?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakobroehrl jakobroehrl jakobroehrl approved these changes

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

Assignees
No one assigned
Labels
3. to review enhancement
Projects
None yet
Milestone
🚀 Next major 1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@juliusknorr @sudwhiwdh @jakobroehrl