move card to another board

[jakobroehrl]

@juliushaertl
How can I retrieve the stacks from another board?
In the stacks store are only the stacks from the current board.
Thanks!

[juliusknorr]

Hm, so either we refactor the store to store all stacks and just return the ones related to the current board id or we just do a temporary api request to fetch the stacks from the foreign board in the modal component when trying to move. I think the second approach would be fine for now, since we do not really need the stack list for any other part of the app.

[jakobroehrl]

@juliushaertl
Tried to implement the API call.
Do you see a problem with that? I can't get the Stacks to the UI, but the data is there, proved with a console.log, thanks!

[jakobroehrl]

@skjnldsv
Could you check this please?

deck/src/components/cards/CardItem.vue

Lines 114 to 134 in 27b8c79

	stacksBySelectedBoard() {
	if (this.selectedBoard === '') {
	return []
	}
	let url = OC.generateUrl('/apps/deck/stacks/' + this.selectedBoard.id)
	axios.get(url)
	.then(
	(response) => {
	return Promise.resolve(response.data)
	},
	(err) => {
	return Promise.reject(err)
	}
	)
	.catch((err) => {
	return Promise.reject(err)
	}).then((result) => {
	return result
	})
	},

I don't get the stacks on the UI, but a console.log in line 132 shows me the values.
Do you have an idea?

Thanks!

[skjnldsv]

Use try...catch instead of chaining .then and .catch :)
With async/await
This will help you figuring things out :)

[skjnldsv]

Also, you do not want to use a request in a computed.
Either load it once on beforeMount and store the results in a local data, or use the dedicated multiselect asynchronous method https://vue-multiselect.js.org/#sub-asynchronous-select

[juliusknorr]

@jakobroehrl Would be cool if you could try assigning labels to represent the state of the pr, that way it is easier to see in the overview if they need some attention for reviewing. 😉

Edit: And the 1.0.0 milestone, so we don't miss one of the awesome features you do in the changelog when releasing.

[jakobroehrl]

@juliushaertl Could you review please and merge if everything is fine?

[juliusknorr]

It would be great if we could do some UI polishing to the modal before merging:

• Button alignment (see other comments)
• Add spacing to the multiselect boxes
• Give the modal a more decent size, currently it looks way to big for the two options we have

[juliusknorr]

A proper max-width/max-height would be good for small screen sizes

[juliusknorr]

.multiselect is not inside the button ;)

[jakobroehrl]

done