Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign card view #938

Closed
stefan-niedermann opened this issue Mar 14, 2019 · 13 comments
Closed

Redesign card view #938

stefan-niedermann opened this issue Mar 14, 2019 · 13 comments

Comments

@stefan-niedermann
Copy link
Member

stefan-niedermann commented Mar 14, 2019

Design session for the Android client with @jancborchardt brought up a detail issue:

Instead of displaying an icon when a description is present we will show on android the first line (truncated description).

Maybe this should be the same behavior on the server app?

deck


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@juliusknorr
Copy link
Member

Makes sense to me 👍

@stefan-niedermann
Copy link
Member Author

Just for docu: this is how a card looks like on the Android app currently:

grafik

@juliusknorr
Copy link
Member

@jancborchardt I'm not sure if we actually should condense the labels, this makes them look to similar to avatars and also doesn't provide enought information what the label is about. The text should be fully visible I think, since otherwise users will always need to remember which labels they have on their boards and the first letter isn't a clear indicator. Just think of labels as we use them in the server repo, where we prefix labels for grouping. ("feature: files" and "feature: settings" have the same color and same beginning but they still should be distinguishable in the UI)

@juliusknorr
Copy link
Member

@stefan-niedermann Appart from the comment above the new layout looks much cleaner. 👍 Avatars are displayed in the bottom right (just to have that referenced here as well)

@fti7
Copy link

fti7 commented Apr 4, 2019

Why not moving the labels to the top? like in the other kanban tools?
Trello usually condenses it by default.
In the most Boards there are just a handful Labels; No need for a Text
But it also allow to uncondense it via an Click.

Screenshot from 2019-04-04 14-13-50
Screenshot from 2019-04-04 14-14-06

Personally i would also like to see such an layout in the Web App. The current layout needs too much space if you have many cards :-)

@jancborchardt
Copy link
Member

@fti7 the first screenshot looks really good, but the issue here is that then the label only relies on color as a distinction and would thus be difficult to distinguish for people with color vision difficulties.

But it also allow to uncondense it via an Click.

Click/tap opens the details at the moment.


@stefan-niedermann I don’t fully remember what was the last state but I remember we had a nice solution in the Android app on the last day of the Contributor Week after the input of @jenniferpiperek? As far as I remember we and @juliushaertl were quite happy with that. Could you post a screenshot? :)

@juliusknorr
Copy link
Member

juliusknorr commented Apr 18, 2019

@jancborchardt This is the android app layout #938 (comment)

https://user-images.githubusercontent.com/4741199/54383793-28ca6380-4693-11e9-8e74-1145fb862154.png

This is the current look in the web UI:
Compact:
image
Normal
image

As written above I'm not to happy with just showing the first letter of the label, as this might lead to confusion if users have multiple labels of the same color.

Since we have a compact view in the web UI, how about just showing color labels on that compact mode and expand the information if the regular mode is used similar to this:

Compact:
https://user-images.githubusercontent.com/7014664/55554929-5039ac80-56e4-11e9-9ab4-d53777bd5fcd.png

Normal:
https://user-images.githubusercontent.com/7014664/55554930-53349d00-56e4-11e9-916d-cde5cf48221d.png

I would prefer to not move the labels to the top, since they distract from what is actually the main information, the card name.

@juliusknorr juliusknorr changed the title Show (truncated) first line of description instead of icon Redesign card view Apr 18, 2019
@jancborchardt
Copy link
Member

This is the android app layout #938 (comment)

Yep, I got that, but since it was from March 14 I thought on the last day of the hackweek we did some additional work on it? I had remembered @stefan-niedermann worked on it some more with some layout improvements. Maybe I misremember.

@jakobroehrl
Copy link
Contributor

@jancborchardt
What do you think about the last state? (Server App)
grafik

Thanks!

@jancborchardt
Copy link
Member

@jakobroehrl good stuff! Only 2 things:

  • I’d say tags should never wrap lines but be forced into one line. If there’s more tags, they should just ellipsize. Maybe with flexbox so each of the tags ellipsizes a bit?
  • The people avatars/circles should overlap a bit like we do in the Text app:
    Text app high dpi avatars blurry

@jakobroehrl
Copy link
Contributor

@jancborchardt Thanks, I will try to implement it.
Maybe you could review the complete VUE Implementation when we are ready to release?

@juliusknorr
Copy link
Member

Closing as this was implemented in the vue branch and is now merged to master.

@alexanderdd
Copy link

discussion continues here stefan-niedermann/nextcloud-deck#298

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants