Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate on a card that comments were made #730

Closed
bpcurse opened this issue Nov 22, 2018 · 14 comments
Closed

Indicate on a card that comments were made #730

bpcurse opened this issue Nov 22, 2018 · 14 comments

Comments

@bpcurse
Copy link
Contributor

bpcurse commented Nov 22, 2018

Is your feature request related to a problem? Please describe.
At the moment you cannot see if anyone commented on a card if you do not open the details and click on the corresponding tab.

Describe the solution you'd like
Alike the paper symbol that is displayed on the card if a description exists, a ballon / speech bubble symbol should be displayed next to the paper symbol if a comment was made.

Describe alternatives you've considered
A more sophisticated approach could show the number of comments inside or next to the balloon.


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@juliusknorr
Copy link
Member

We actually have the same behavior here as the files app. If you were mentioned in a comment we show the speech bubble on the card. cc @nextcloud/designers Maybe we should show it in general if there were new comments and highlight it a bit more if the user has been mentioned?

@bpcurse
Copy link
Contributor Author

bpcurse commented Nov 22, 2018

I really like the idea of showing it in general when comments exist and highlighting it in some way if the user has been mentioned. As people use nextcloud/deck differently especially in regard to notification settings, this could help keeping an overview without cluttering the interface too much. It is a logical addition to the paper symbol I would expect working this way without reading a manual.

@skjnldsv
Copy link
Member

@juliushaertl We could even add a counter?

@jancborchardt
Copy link
Member

A comment icon is good, a counter is a bit information overload and takes more space. In the end it doesn’t really matter if there’s 4 or 5 comments. What’s important is:

  • Were there comments at all?
  • Did any of them mention you?

:)

@juliusknorr
Copy link
Member

Were there comments at all?
Did any of them mention you?

I think those actually only matter if the comments are unread. But maybe we can have a separate icon for comments with mentions?

@jancborchardt
Copy link
Member

We could have something like:

  • Comments icon in grey when there are generally comments on the issue
  • Comments icon in darker grey and red circle in the top right of it (like we do for notifications) when there are unread comments
  • Comments icon in primary color (blue default) with a white @ inside of it when there are new comments mentioning you.

Only one icon would be shown at a time. And we could/should actually use the same style of icons for Files. cc @nextcloud/designers

@juliusknorr
Copy link
Member

@jancborchardt That sounds like a good solution to me. 👍

@jancborchardt
Copy link
Member

@juliushaertl cool! I’ll make the icons then and add them to core.

@bpcurse
Copy link
Contributor Author

bpcurse commented Dec 4, 2018

@jancborchardt @juliushaertl I just made a quick and ugly mockup of the design:

The variations "comments were made" and "comment(s) unread" in grey fit in very nicely, but I'm not so sure of the blue one?

deck_mock_up_card_comments2

@natrius
Copy link

natrius commented May 30, 2019

Any updates on this one?

@blue one: My suggestion would be just an '@' at the top. No blue colour.

  • Grey: Messages made
  • Red dot: New messages
  • @: Mentioned

@jakobroehrl
Copy link
Contributor

jakobroehrl commented May 14, 2020

In the latest version there is a icon for unread comments.
If a user is mentioned in a comment there is a nextcloud notification, too.

grafik

@jakobroehrl jakobroehrl removed their assignment May 14, 2020
@juliusknorr
Copy link
Member

@juliushaertl cool! I’ll make the icons then and add them to core.

@jancborchardt Did anything happen in that regards? 😉

@pascalfranke

This comment was marked as spam.

@juliusknorr
Copy link
Member

We show it always these days, will close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants