-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move comments to separate sidebar tab #1073
Comments
This was implemented after the general discussion of merging activity/comments into one timeline in nextcloud/server#658. Moving them to the description tab seems wrong to me, as it is clearly something different. The main issue seems to be that the comments are distributed between all the activity entries. What do you think about allowing to filter the timeline view to just show comments? That should solve the usability issue you have. |
No, the main issue is that we did not even know comments are possible. Just after i was just clicking around because of something else i discovered this. Together with #730 it would be easier to start with, but now. Discover by accident. My suggestions would be:
I would never actively search in a timeline for a new comment. As said, i expect there things like "New comment", "Comment edited", "Comment deleted" and stuff like that, but not the comment itself. Your suggested solution is not bad but just in this case at least add under "Description" a Info in italic or something like this "Comments can be found in the timeline". As said, we did not even know comments are possible. After discovering it once, everything is fine. But the path to discovering the comments... |
I see your point, maybe @jancborchardt has an idea since the discoverability of of comments will be a general issue with the unified timeline. |
Same issue described here #728. The problem is, that displaying comments in the timeline may have some logic in it, but it definitively is not intuitive. No one will search there for comments.
I would love to see a solution, where the comments simply are shown under the description text (if there is any). This seems to be intuitive to me. |
An essential part of having the comments discoverable is that the "Activity" tab should be the first, leftmost tab and thus active by default. The middle tab is "Sharing" and the last tab is for "Details" (which also contains description etc.) This is how we specified it in Sidebar standardization nextcloud/server#10289 |
The comments need to be readable as a stream without regard to who moved a card to a different stack (list), modified the description in some way, added or removed an attachment etc.. Comments are the discussion of the item as described - so as @bpcurse suggests, having comments below the description is probably both the most intuitive and makes them most useful - and the description (details) should be the default view for a selected card because it's likely essential reading for anyone new to the card. |
Alright, let’s go for an exception here then. @juliushaertl what do you think? |
Please, do not put the activity-tab in as the first tab, thats a bad idea. At first i want to see the description of the tab. Most of the time i don't care about the activity at all. That is just for special occasions i have to check something. So, the suggested solution would be the first i mentioned, divide the "Description" tab into "Description" and "Comments". Renaming the Tab into "General" would also be possible, so its, well, more general. |
@natrius I already agreed to doing that. :) |
Fine by me. Lets do this in the vue rewrite then 👍 |
This comment has been minimized.
This comment has been minimized.
@juliushaertl is there anything we can do to help (test or dev)? |
Feel free to checkout the vue branch if you want to do some early testing. Regarding comments @jakobroehrl is working hard on finishing the vue implementation and the only big issue to complete feature parity is file attachments as far as I can see. We will do some beta releases for the new version in a couple of weeks as well i think. If you want to help with development you can have a look at our vue migration project at https://github.com/nextcloud/deck/projects/1 Any contribution is welcome 😉 |
@juliushaertl will see what can be done. Will certainly be up for "live testing" beta releases - is there somewhere we can subscribe to learn when betas are available? |
I'll publish it as a release to github so if you want to subscribe to it, there is an RSS feed: https://github.com/nextcloud/deck/releases.atom |
We have fresh nightly builds available at https://github.com/nextcloud/deck/releases/tag/nightly for early testing if you want, but there is still a lot of things missing (see https://github.com/nextcloud/deck/projects/1 for details) While activity and comments are only partly working atm, the tabs are already separated so let's close this. |
@juliushaertl Activity and comments appear to be merged back in v1b2? |
No, nothing should have changed in that regard |
Ok, looks like our test server is reverting beta 2 to current release (but didn't do that to beta 1 - odd) |
Is your feature request related to a problem? Please describe.
I'm always frustrated i have to search comments. I introduced a friend to deck for marriage planning and he wrote some comments in the description because he did not actually thought that comments are 1, possible at all and 2, they are found in the timeline.The timeshould not contain anything active. It should just be a passive timeline in case i want to check something. How it was moved and so on.
Describe the solution you'd like
Move the comments itself in the Description at the bottom in an extra section.
In the timeline there still should be a "x wrote a comment." or "x deleted a comment".
Describe alternatives you've considered
Alternatively introduce a new tab, so its Description, Comments, Attachment, Timeline.
Additional context
or
Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
The text was updated successfully, but these errors were encountered: