Adjust .modal-container height

[gnilebein]

Describe the bug
In previous versions, the modal container was larger. Now it is only provided with a max-height of 90%. My suggestion would be to set the height for the modal-container in general back to 90%. This also prevents the modal window from "jumping" when you click on the Edit button.

To Reproduce
Steps to reproduce the behavior:

1. See Screenshot

Expected behavior
Fixed size for modal Window

Screenshots

Client details:

• OS: Windows
• Browser Firefox & Chrome
• Version [e.g. 22]
• Device: Desktop

Server details

Operating system: Ubuntu

Web server: Apache 2.4

Database: MySQL

PHP version: 8.0

Nextcloud version: Nextcloud Hub 3 (25.0.1)

Where did you install Nextcloud from: Updater

Signing status:

No errors have been found.

List of activated apps:

If you have access to your command line run e.g.:
Enabled:
  - calendar: 4.1.0
  - circles: 25.0.0
  - cloud_federation_api: 1.8.0
  - collectives: 2.1.1
  - comments: 1.15.0
  - contacts: 5.0.1
  - contactsinteraction: 1.6.0
  - dav: 1.24.0
  - deck: 1.8.2
  - drawio: 1.0.5
  - federatedfilesharing: 1.15.0
  - federation: 1.15.0
  - files: 1.20.1
  - files_automatedtagging: 1.15.0
  - files_lock: 24.0.1
  - files_mindmap: 0.0.27
  - files_pdfviewer: 2.6.0
  - files_retention: 1.14.0
  - files_rightclick: 1.4.0
  - files_sharing: 1.17.0
  - files_trashbin: 1.15.0
  - files_versions: 1.18.0
  - forms: 3.0.1
  - groupfolders: 13.1.0
  - logreader: 2.10.0
  - lookup_server_connector: 1.13.0
  - notifications: 2.13.1
  - oauth2: 1.13.0
  - password_policy: 1.15.0
  - photos: 2.0.0
  - polls: 4.0.0
  - privacy: 1.9.0
  - provisioning_api: 1.15.0
  - related_resources: 1.0.3
  - richdocuments: 7.0.1
  - serverinfo: 1.15.0
  - settings: 1.7.0
  - sharebymail: 1.15.0
  - side_menu: 3.4.1
  - snappymail: 2.22.5
  - systemtags: 1.15.0
  - tasks: 0.14.5
  - text: 3.6.0
  - theming: 2.0.1
  - theming_customcss: 1.12.0
  - twofactor_backupcodes: 1.14.0
  - twofactor_nextcloud_notification: 3.5.0
  - twofactor_totp: 7.0.0
  - updatenotification: 1.15.0
  - user_external: 3.0.0
  - user_status: 1.5.0
  - viewer: 1.9.0
  - workflowengine: 2.7.0
Disabled:
  - activity: 2.16.0
  - admin_audit
  - apporder: 0.15.0
  - bruteforcesettings
  - dashboard: 7.2.0
  - encryption
  - extract: 1.3.5
  - files_external
  - files_markdown: 2.3.6
  - files_texteditor: 2.15.0
  - firstrunwizard: 2.11.0
  - impersonate: 1.11.0
  - nextcloud_announcements: 1.10.0
  - recommendations: 1.0.0
  - support: 1.7.0
  - survey_client: 1.10.0
  - suspicious_login
  - user_ldap
  - weather_status: 1.2.0
  - workflow_pdf_converter: 1.10.0

[reox]

Please also change it back to keep also the menu icons on the same height of the screen. Otherwise the window jumps around for the different views:

[reox]

This is very annoying but I think I have found a quick-fix.
Instead of using a min-height of 100px, one could use a min-height of 300px here:

deck/src/components/card/Description.vue

Lines 325 to 326 in 6c4a127

	#description-preview {
	min-height: 100px;

300px is also the minimum height of the CodeMirror-scroll div when using the edit mode.

I simply changed that value now in nextcloud/apps/deck/js/deck-main.js and it solves this issue for me at the moment...
Should I send a PR with that change?

EDIT: I just realized, this does not solve the issue in any cases. If there is no descrption yet, then there is also no description-preview but only a p element with class placeholder. Of course, you could set the min-height there as well but I'm not sure where this class is used elsewhere.