Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct spelling #941

Merged
merged 2 commits into from
Mar 29, 2022
Merged

Correct spelling #941

merged 2 commits into from
Mar 29, 2022

Conversation

Valdnet
Copy link
Contributor

@Valdnet Valdnet commented Mar 29, 2022

Signed-off-by: Valdnet [email protected]

@Valdnet Valdnet self-assigned this Mar 29, 2022
Copy link
Collaborator

@christianlupus christianlupus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@codecov
Copy link

codecov bot commented Mar 29, 2022

Codecov Report

Merging #941 (c9d6573) into master (3281ecb) will not change coverage.
The diff coverage is 50.00%.

❗ Current head c9d6573 differs from pull request most recent head aa383e6. Consider uploading reports for the commit aa383e6 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #941   +/-   ##
=======================================
  Coverage   28.50%   28.50%           
=======================================
  Files          29       29           
  Lines        1540     1540           
=======================================
  Hits          439      439           
  Misses       1101     1101           
Flag Coverage Δ
integration 5.51% <0.00%> (ø)
unittests 22.98% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/Service/RecipeService.php 0.00% <0.00%> (ø)
lib/Service/ThumbnailService.php 100.00% <100.00%> (ø)

@@ -1100,7 +1100,7 @@ public function parseRecipeFile($file) {
public function getRecipeImageFileByFolderId($id, $size = 'thumb'): File {
$recipe_folders = $this->root->getById($id);
if (count($recipe_folders) < 1) {
throw new Exception($this->il10n->t('Recipe with id %d not found.', [$id]));
throw new Exception($this->il10n->t('Recipe with ID %d not found.', [$id]));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Valdnet i have one question regarding this change: is it only syntactical to have a better English writing or is this one a technical thing (do we have a duplicate strong here somewhere)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the ID is a direct identifier and points to an individual, the item or item should be in uppercase.

@christianlupus
Copy link
Collaborator

If you do not mind, i will append a note to the Changelog. Your are free to do this yourself, i will need some time to get to my machine.

@github-actions
Copy link

Unit Test Results

     22 files       22 suites   7m 59s ⏱️
   120 tests    120 ✔️ 0 💤 0
1 320 runs  1 320 ✔️ 0 💤 0

Results for commit aa383e6.

@Valdnet
Copy link
Contributor Author

Valdnet commented Mar 29, 2022

If you do not mind, i will append a note to the Changelog.

No problem, you can add 😉.

@Valdnet Valdnet merged commit 5c26142 into master Mar 29, 2022
@delete-merged-branch delete-merged-branch bot deleted the Valdnet-patch-1 branch March 29, 2022 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants