-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct spelling #941
Correct spelling #941
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Codecov Report
@@ Coverage Diff @@
## master #941 +/- ##
=======================================
Coverage 28.50% 28.50%
=======================================
Files 29 29
Lines 1540 1540
=======================================
Hits 439 439
Misses 1101 1101
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@@ -1100,7 +1100,7 @@ public function parseRecipeFile($file) { | |||
public function getRecipeImageFileByFolderId($id, $size = 'thumb'): File { | |||
$recipe_folders = $this->root->getById($id); | |||
if (count($recipe_folders) < 1) { | |||
throw new Exception($this->il10n->t('Recipe with id %d not found.', [$id])); | |||
throw new Exception($this->il10n->t('Recipe with ID %d not found.', [$id])); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Valdnet i have one question regarding this change: is it only syntactical to have a better English writing or is this one a technical thing (do we have a duplicate strong here somewhere)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the ID is a direct identifier and points to an individual, the item or item should be in uppercase.
If you do not mind, i will append a note to the Changelog. Your are free to do this yourself, i will need some time to get to my machine. |
No problem, you can add 😉. |
Signed-off-by: Valdnet [email protected]