Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add placeholder text to image input field #835

Merged

Conversation

seyfeb
Copy link
Collaborator

@seyfeb seyfeb commented Oct 28, 2021

Indicate that URLs can be used as a source for images and not only the Nextcloud instance

Closes #771

@seyfeb seyfeb force-pushed the issues/771-indicate-possible-import-of-image-from-url-in-ui branch from 2e955e3 to d252e1d Compare October 28, 2021 16:50
@codecov
Copy link

codecov bot commented Oct 28, 2021

Codecov Report

Merging #835 (9cb87cf) into master (8ed0bf5) will not change coverage.
The diff coverage is n/a.

❗ Current head 9cb87cf differs from pull request most recent head f775513. Consider uploading reports for the commit f775513 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #835   +/-   ##
=======================================
  Coverage   21.27%   21.27%           
=======================================
  Files          20       20           
  Lines        1551     1551           
=======================================
  Hits          330      330           
  Misses       1221     1221           
Flag Coverage Δ
integration 7.09% <ø> (ø)
unittests 14.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions
Copy link

github-actions bot commented Oct 28, 2021

Unit Test Results

  20 files    20 suites   8m 0s ⏱️
  66 tests   66 ✔️ 0 💤 0
660 runs  660 ✔️ 0 💤 0

Results for commit f775513.

♻️ This comment has been updated with latest results.

@seyfeb seyfeb force-pushed the issues/771-indicate-possible-import-of-image-from-url-in-ui branch from d252e1d to f775513 Compare October 28, 2021 17:13
@seyfeb seyfeb merged commit 953c776 into master Oct 28, 2021
@delete-merged-branch delete-merged-branch bot deleted the issues/771-indicate-possible-import-of-image-from-url-in-ui branch October 28, 2021 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Indicate possible import of image from URL in UI
1 participant