Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/1509 truncate recipe name in db #2324

Merged
merged 6 commits into from
May 20, 2024
Merged

Fix/1509 truncate recipe name in db #2324

merged 6 commits into from
May 20, 2024

Conversation

christianlupus
Copy link
Collaborator

@christianlupus christianlupus commented May 20, 2024 •
edited
Loading

Topic and Scope

Closes #1509

Concerns/issues

Different Databases and character sets might behave differently. This must be considered in the future.

Formal requirements

There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.

  • I did check that the app can still be opened and does not throw any browser logs
  • I created tests for newly added PHP code (check this if no PHP changes were made)
  • I updated the OpenAPI specs and added an entry to the API changelog (check if API was not modified)
  • I notified the matrix channel if I introduced an API change

@github-actions GitHub Actions
Copy link

github-actions bot commented May 20, 2024 •
edited
Loading

Test Results

   12 files    580 suites   1m 32s ⏱️
  567 tests   567 ✅ 0 💤 0 ❌
2 268 runs  2 267 ✅ 1 💤 0 ❌

Results for commit cd5a218.

♻️ This comment has been updated with latest results.

@christianlupus
Truncate the name in the DB to match the column length
78f3c33 
Signed-off-by: Christian Wolf <[email protected]>
@christianlupus
Add some basic tests
a5a3072 
Signed-off-by: Christian Wolf <[email protected]>
@christianlupus
Update Changelog
2053d0c 
Signed-off-by: Christian Wolf <[email protected]>
@christianlupus
Make online linters happy
850e7ee 
Signed-off-by: Christian Wolf <[email protected]>
@christianlupus
Fix unit tests
cd5a218 
Signed-off-by: Christian Wolf <[email protected]>
@christianlupus christianlupus force-pushed the fix/1509-truncate-recipe-name-in-db branch from bdbf78a to cd5a218 Compare May 20, 2024 19:32
@christianlupus
Copy link
Collaborator Author

/approve

@christianlupus christianlupus marked this pull request as ready for review May 20, 2024 19:33
nextcloud-cookbook-bot
nextcloud-cookbook-bot approved these changes May 20, 2024
View reviewed changes
Copy link
Collaborator

@nextcloud-cookbook-bot nextcloud-cookbook-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approved by GitHub action on behalf of /approve

@christianlupus christianlupus enabled auto-merge May 20, 2024 19:39
@christianlupus christianlupus merged commit 714671a into master May 20, 2024
29 checks passed
@christianlupus christianlupus deleted the fix/1509-truncate-recipe-name-in-db branch May 20, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nextcloud-cookbook-bot nextcloud-cookbook-bot nextcloud-cookbook-bot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed to import from hellofresh.com
2 participants
@christianlupus @nextcloud-cookbook-bot