Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workaround by defining label outside #2281

Merged
merged 2 commits into from
May 1, 2024

Conversation

christianlupus
Copy link
Collaborator

Topic and Scope

Currently, there is a error logged in the browser when opening the recipe list:

grafik

This PR just sets labelOutside to true to quite the warning.

Concerns/issues

This is just a workaround until the new frontend is in place.

Formal requirements

There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.

  • I did check that the app can still be opened and does not throw any browser logs
  • I created tests for newly added PHP code (check this if no PHP changes were made)
  • I updated the OpenAPI specs and added an entry to the API changelog (check if API was not modified)
  • I notified the matrix channel if I introduced an API change

Signed-off-by: Christian Wolf <[email protected]>
@christianlupus christianlupus marked this pull request as ready for review May 1, 2024 08:02
@christianlupus
Copy link
Collaborator Author

/approve

@christianlupus christianlupus enabled auto-merge May 1, 2024 08:02
Copy link
Collaborator

@nextcloud-cookbook-bot nextcloud-cookbook-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approved by GitHub action on behalf of /approve

@christianlupus christianlupus merged commit 04db62d into master May 1, 2024
29 checks passed
@christianlupus christianlupus deleted the fix/error-message-in-browser-logs branch May 1, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants