Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/1945 print view shows irrelevant elements #1949

Merged

Conversation

seyfeb
Copy link
Collaborator

@seyfeb seyfeb commented Dec 7, 2023

Topic and Scope

In recipe-print view hide

  • yield calculator
  • yield-calculation warnings
  • ingredient-copy button

Closes #1945

Before
Screenshot 2023-12-07 at 16 53 27

After
Screenshot 2023-12-07 at 16 51 03

Concerns/issues

None

Formal requirements

There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.

  • I did check that the app can still be opened and does not throw any browser logs
  • I created tests for newly added PHP code (check this if no PHP changes were made)
  • I updated the OpenAPI specs and added an entry to the API changelog (check if API was not modified)
  • I notified the matrix channel if I introduced an API change

…edient copy button, ingredient-calculator parsing error

Signed-off-by: Sebastian Fey <[email protected]>
…yield calculation in default style.

Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
Copy link

github-actions bot commented Dec 7, 2023

Test Results

     27 files  1 287 suites   5m 33s ⏱️
   552 tests    552 ✔️ 0 💤 0
4 968 runs  4 967 ✔️ 1 💤 0

Results for commit f508349.

♻️ This comment has been updated with latest results.

@seyfeb
Copy link
Collaborator Author

seyfeb commented Dec 7, 2023

/approve

Copy link
Collaborator

@nextcloud-cookbook-bot nextcloud-cookbook-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approved by GitHub action on behalf of /approve

@seyfeb
Copy link
Collaborator Author

seyfeb commented Dec 7, 2023

/cb-backport main-0.10.x

@seyfeb
Copy link
Collaborator Author

seyfeb commented Dec 8, 2023

/cb-backport main-0.10.x

@seyfeb seyfeb merged commit 7820f37 into nextcloud:master Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Print view shows irrelevant elements
2 participants