-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load config explicitly and remove setup routine of settings component #1892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1892 +/- ##
=======================================
Coverage 79.55% 79.55%
=======================================
Files 89 89
Lines 2582 2582
=======================================
Hits 2054 2054
Misses 528 528
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Christian Wolf <[email protected]>
seyfeb
approved these changes
Nov 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except for the two minor points it looks fine to me.
Signed-off-by: Sebastian Fey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Topic and Scope
This is a first step to prevent regular updating of the config on each page reload.
Closes #1752
Concerns/issues
The PR just covers the basic changes. The migration to the InitialState is not yet carried out.
Formal requirements
There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.