Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix filters to allow for multi-line text in some fields #1162

Merged
merged 3 commits into from
Aug 22, 2022

Conversation

christianlupus
Copy link
Collaborator

This fixes a regression introduced in #1097. It was not possible to type multi-line text in instructions, ingredients, and tools fields.

@codecov
Copy link

codecov bot commented Aug 22, 2022

Codecov Report

Merging #1162 (c64e8fe) into master (65a32c1) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

❗ Current head c64e8fe differs from pull request most recent head afe174a. Consider uploading reports for the commit afe174a to get more accurate results

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1162      +/-   ##
============================================
- Coverage     57.68%   57.63%   -0.06%     
  Complexity      735      735              
============================================
  Files            73       73              
  Lines          2290     2287       -3     
============================================
- Hits           1321     1318       -3     
  Misses          969      969              
Flag Coverage Δ
integration 5.81% <100.00%> (+4.02%) ⬆️
migration 4.06% <0.00%> (+<0.01%) ⬆️
unittests 51.77% <100.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/Helper/Filter/JSON/FixInstructionsFilter.php 100.00% <ø> (ø)
lib/Helper/Filter/JSON/FixIngredientsFilter.php 100.00% <100.00%> (ø)
lib/Helper/Filter/JSON/FixToolsFilter.php 100.00% <100.00%> (ø)

@github-actions
Copy link

github-actions bot commented Aug 22, 2022

Unit Test Results

     33 files       33 suites   7m 35s ⏱️
   414 tests    414 ✔️ 0 💤 0
4 554 runs  4 554 ✔️ 0 💤 0

Results for commit afe174a.

♻️ This comment has been updated with latest results.

Signed-off-by: Christian Wolf <[email protected]>
@christianlupus christianlupus force-pushed the fix/multiline-filter branch 2 times, most recently from c64e8fe to afe174a Compare August 22, 2022 15:00
@christianlupus christianlupus marked this pull request as ready for review August 22, 2022 15:01
@christianlupus christianlupus merged commit 31ad96c into master Aug 22, 2022
@christianlupus christianlupus deleted the fix/multiline-filter branch August 22, 2022 15:08
@christianlupus christianlupus added this to the Release 0.9.14 milestone Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant