Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename settings to "Contacts settings" #2861

Merged
merged 1 commit into from
Jul 21, 2022

Conversation

PVince81
Copy link
Member

Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the screenshot it says "Contact" without the s but in the code it looks fine. :)

@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

Merging #2861 (f72f1c1) into main (40471bf) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main    #2861      +/-   ##
============================================
- Coverage     17.93%   17.92%   -0.02%     
  Complexity      253      253              
============================================
  Files           103      103              
  Lines          3233     3235       +2     
  Branches        451      451              
============================================
  Hits            580      580              
- Misses         2458     2460       +2     
  Partials        195      195              
Impacted Files Coverage Δ
src/components/AppNavigation/RootNavigation.vue 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40471bf...f72f1c1. Read the comment docs.

@miaulalala miaulalala merged commit 6808d06 into main Jul 21, 2022
@miaulalala miaulalala deleted the bugfix/server/32350/rename-settings branch July 21, 2022 14:37
@welcome
Copy link

welcome bot commented Jul 21, 2022

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/contacts/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22
Most developers hang out on IRC. So join #nextcloud-contacts and #nextcloud-dev on Freenode for a chat!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants