-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resize maximum dimensions for pictures coming from SocialApiService #2745
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2745 +/- ##
=============================================
+ Coverage 18.04% 68.76% +50.72%
- Complexity 247 251 +4
=============================================
Files 97 22 -75
Lines 3170 714 -2456
Branches 439 0 -439
=============================================
- Hits 572 491 -81
+ Misses 2405 223 -2182
+ Partials 193 0 -193 Continue to review full report at Codecov.
|
4ef3551
to
0a4d8d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You get bonus points for declare(strict_types=1); ;-)
Signed-off-by: Thomas Citharel <[email protected]>
0a4d8d5
to
b6dd2e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good idea.
But I am not sure it closes #2743 completely - |
/backport to stable4.1 |
Closes #2743
Make sure every picture fetched from SocialAPIService has a maximum size of 256 pixels.
Should we add an extra condition to reject on size being to high?
Would be nice to test ImageResizer with a few test pictures too.