-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set default language for TNTSearch #1065
Conversation
84f4301
to
77e1413
Compare
d9aaddf
to
caa58e5
Compare
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
caa58e5
to
b3ab859
Compare
@mejo- @juliushaertl can you review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me with one comment regarding the default value
5fc5005
to
b70afbd
Compare
test failures looks unrelated |
Signed-off-by: Konstantin Myakshin <[email protected]>
b70afbd
to
ce2f2b1
Compare
'uk' => 'Ukrainian', | ||
]; | ||
|
||
private const UNSUPPORTED_LANGUAGE = 'No'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be some string that is less likely to be similar to no
(for "Norwegian")?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I asked earlier and this is just how tntsearch expects it https://github.com/teamtnt/tntsearch/blob/13096686f81856addcd2eabc5eb73a470be36fb4/src/Engines/EngineTrait.php#L167-L171
I think the constant is the best we can get for that ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, thanks for the pointer. Then the PR is good to go π Thanks for the contribution @Koc!
π Summary
This change improves morphology in search functionality by providing correct Stemmer for TNTSearch
πΌοΈ Screenshots
π§ TODO
π Checklist
npm run lint
/npm run stylelint
/composer run cs:check
)