Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default language for TNTSearch #1065

Merged
merged 1 commit into from
Mar 9, 2024

Conversation

Koc
Copy link
Contributor

@Koc Koc commented Dec 29, 2023

πŸ“ Summary

This change improves morphology in search functionality by providing correct Stemmer for TNTSearch

πŸ–ΌοΈ Screenshots

🏚️ Before 🏑 After
image image

🚧 TODO

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

@Koc Koc force-pushed the feature/set-default-language branch from 84f4301 to 77e1413 Compare December 29, 2023 16:46
@juliusknorr juliusknorr requested a review from mejo- January 2, 2024 09:17
@Koc Koc force-pushed the feature/set-default-language branch 2 times, most recently from d9aaddf to caa58e5 Compare January 8, 2024 10:50
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

@Koc Koc force-pushed the feature/set-default-language branch from caa58e5 to b3ab859 Compare February 6, 2024 23:30
@Koc
Copy link
Contributor Author

Koc commented Feb 6, 2024

@mejo- @juliushaertl can you review?

Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with one comment regarding the default value

@Koc Koc force-pushed the feature/set-default-language branch 3 times, most recently from 5fc5005 to b70afbd Compare February 16, 2024 17:29
@juliusknorr juliusknorr added enhancement New feature or request 4. to release labels Feb 27, 2024
@Koc
Copy link
Contributor Author

Koc commented Mar 1, 2024

test failures looks unrelated

Signed-off-by: Konstantin Myakshin <[email protected]>
@mejo- mejo- force-pushed the feature/set-default-language branch from b70afbd to ce2f2b1 Compare March 6, 2024 20:53
'uk' => 'Ukrainian',
];

private const UNSUPPORTED_LANGUAGE = 'No';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be some string that is less likely to be similar to no (for "Norwegian")?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I asked earlier and this is just how tntsearch expects it https://github.com/teamtnt/tntsearch/blob/13096686f81856addcd2eabc5eb73a470be36fb4/src/Engines/EngineTrait.php#L167-L171

I think the constant is the best we can get for that ;)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thanks for the pointer. Then the PR is good to go 😊 Thanks for the contribution @Koc!

@mejo- mejo- merged commit 4f737c4 into nextcloud:main Mar 9, 2024
39 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants