Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to probeCircles() in CircleHelper #498

Closed
mejo- opened this issue Jan 10, 2023 · 1 comment · Fixed by #1592
Closed

Switch to probeCircles() in CircleHelper #498

mejo- opened this issue Jan 10, 2023 · 1 comment · Fixed by #1592
Labels
backend technical debt

Comments

@mejo-
Copy link
Member

mejo- commented Jan 10, 2023

Once we remove support for Nextcloud 25 (and only support 26 onwards), we should switch to probCircles() in CircleHelper. It's lighter and the recommended way to get circles.
@mejo- mejo- added the backend label Jan 10, 2023
@mejo-
Copy link
Member Author

mejo- commented Jul 2, 2024

I quickly looked into it and am not sure whether that's possible easily. probeCircles() uses cached memberships. We even pass refreshCache = true to getCircles() to get accurate data as we might run into race conditions otherwise when dealing with circles.

@ArtificialOwl how is the membership cache in circles handled? Does it get invalidated by write operations? Or can we get outdated data from probeCircles()?

mejo- added a commit that referenced this issue Nov 18, 2024
@mejo-
fix(circles): Use probeCircles() instead of getCircles()
90c17a7 
`probeCircles()` is lighter and more performant.

Fixes: #498

Signed-off-by: Jonas <[email protected]>
mejo- added a commit that referenced this issue Nov 18, 2024
@mejo-
fix(circles): Use probeCircles() instead of getCircles()
af039a3 
`probeCircles()` is lighter and more performant.

Fixes: #498

Signed-off-by: Jonas <[email protected]>
@mejo- mejo- mentioned this issue Nov 18, 2024
Merged
4 tasks
mejo- added a commit that referenced this issue Nov 18, 2024
@mejo-
fix(circles): Use probeCircles() instead of getCircles()
b518c24 
`probeCircles()` is lighter and more performant.

Fixes: #498

Signed-off-by: Jonas <[email protected]>
mejo- added a commit that referenced this issue Nov 25, 2024
@mejo-
fix(circles): Use probeCircles() instead of getCircles()
d4c584d 
`probeCircles()` is lighter and more performant.

Fixes: #498

Signed-off-by: Jonas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(circles): Use probeCircles() instead of getCircles() nextcloud/collectives
1 participant
@mejo-