Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catch undef recipient #1794

Merged
merged 1 commit into from
Dec 11, 2024
Merged

catch undef recipient #1794

merged 1 commit into from
Dec 11, 2024

Conversation

ArtificialOwl
Copy link
Member

@ArtificialOwl ArtificialOwl commented Dec 2, 2024

No description provided.

Signed-off-by: Maxence Lange <[email protected]>
@ArtificialOwl ArtificialOwl force-pushed the fix/noid/ignore-orphans-share branch from e56c804 to 6df7ecc Compare December 2, 2024 13:57
@ArtificialOwl ArtificialOwl changed the title ignore orphans shares catch undef recipient Dec 2, 2024
Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be cosmetic (or at least affecting the output) only, so approving without exactly understanding when $recipient->getBasedOn() would be falsy.

@ArtificialOwl
Copy link
Member Author

when a user is deleted, before the maintenance cronjob is executed to remove orphan share

@ArtificialOwl
Copy link
Member Author

/backport to stable30

@ArtificialOwl
Copy link
Member Author

/backport to stable29

@ArtificialOwl
Copy link
Member Author

/backport to stable28

@ArtificialOwl ArtificialOwl merged commit af6395d into master Dec 11, 2024
31 checks passed
@ArtificialOwl ArtificialOwl deleted the fix/noid/ignore-orphans-share branch December 11, 2024 15:11
Copy link

backportbot bot commented Dec 11, 2024

The backport to stable29 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable29
git pull origin stable29

# Create the new backport branch
git checkout -b backport/1794/stable29

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 6df7eccd

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/1794/stable29

Error: Failed to push branch backport/1794/stable29: fatal: could not read Username for 'https://github.com': No such device or address


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants