Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix duplicate name on fedcircle #1744

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

ArtificialOwl
Copy link
Member

@ArtificialOwl ArtificialOwl commented Nov 5, 2024

fix issues when sharing file on federated circles:

  • should fully avoid duplicate name on remotely shared items
  • compat with Files_Sharing/External/Manager

@ArtificialOwl ArtificialOwl force-pushed the fix/noid/fix-duplicate-federated-circles branch 3 times, most recently from ca76ac0 to 40c68a2 Compare November 6, 2024 11:25
use OCP\Migration\SimpleMigrationStep;
use Psr\Log\LoggerInterface;

class Version0031Date20241105133904 extends SimpleMigrationStep {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

attribute missing


try {
$table = $schema->getTable('circles_mountpoint');
if (!$table->hasIndex('dname')) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

name should be 'mp_sid_hash'

Signed-off-by: Maxence Lange <[email protected]>
Signed-off-by: Maxence Lange <[email protected]>
@ArtificialOwl ArtificialOwl force-pushed the fix/noid/fix-duplicate-federated-circles branch from 40c68a2 to 6cddb36 Compare November 27, 2024 15:26
@ArtificialOwl ArtificialOwl merged commit 4bd653d into master Nov 27, 2024
31 checks passed
@ArtificialOwl ArtificialOwl deleted the fix/noid/fix-duplicate-federated-circles branch November 27, 2024 17:03
@ArtificialOwl
Copy link
Member Author

/backport to stable30

@ArtificialOwl
Copy link
Member Author

/backport to stable29

@ArtificialOwl
Copy link
Member Author

/backport to stable28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants