escape html #1415
Merged
escape html #1415
+11
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maxence Lange <[email protected]>
|
/backport to stable27 |
|
/backport to stable26 |
|
/backport to stable25 |
sorbaugh
approved these changes
Oct 16, 2023
nfebe
reviewed
Oct 16, 2023
Comment on lines
+135
to
+140
| return text.toString() | ||
| .split('&').join('&') | ||
| .split('<').join('<') | ||
| .split('>').join('>') | ||
| .split('"').join('"') | ||
| .split('\'').join('''); |
There was a problem hiding this comment.
Suggested change
| return text.toString() | |
| .split('&').join('&') | |
| .split('<').join('<') | |
| .split('>').join('>') | |
| .split('"').join('"') | |
| .split('\'').join('''); | |
| const parser = new DOMParser(); | |
| const doc = parser.parseFromString(text, 'text/html'); | |
| return doc.body.textContent; |
There was a problem hiding this comment.
This would escape any chars not thought about and handle more edge cases, it however looks okay
There was a problem hiding this comment.
tried it, it removes text within <> which might be excessive :)
nfebe
approved these changes
Oct 16, 2023
This was referenced Oct 16, 2023
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.