Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared calendars shouldn't allow adding attendees if the calendar is not yours #5457

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

GretaD
Copy link
Contributor

@GretaD GretaD commented Sep 6, 2023

fixes #5450

Screenshot from 2023-09-07 09-16-12

@GretaD GretaD added 3. to review Waiting for reviews bug labels Sep 6, 2023
@GretaD GretaD self-assigned this Sep 6, 2023
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.03% ⚠️

Comparison is base (d9e67db) 22.63% compared to head (8d2f0fb) 22.61%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5457      +/-   ##
============================================
- Coverage     22.63%   22.61%   -0.03%     
  Complexity      395      395              
============================================
  Files           241      241              
  Lines         11834    11847      +13     
  Branches       2299     2305       +6     
============================================
  Hits           2679     2679              
- Misses         9155     9168      +13     
Flag Coverage Δ
javascript 13.82% <0.00%> (-0.02%) ⬇️
php 64.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/components/Editor/Invitees/InviteesList.vue 0.00% <0.00%> (ø)
src/mixins/EditorMixin.js 3.53% <0.00%> (-0.09%) ⬇️
src/views/EditSidebar.vue 0.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GretaD GretaD force-pushed the fix/shared-calendar-owner branch from 127d2d9 to 8d2f0fb Compare September 7, 2023 07:16
@GretaD GretaD enabled auto-merge September 7, 2023 07:17
@GretaD GretaD added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 7, 2023
@GretaD GretaD merged commit 2edbdbe into main Sep 7, 2023
38 of 40 checks passed
@GretaD GretaD deleted the fix/shared-calendar-owner branch September 7, 2023 07:21
@nunoleite
Copy link

I'm sorry, but i disagree.

On our Nextcloud implementation we have a user that's the Admin, that manages some global things. Like folders and calendars. Because Nextcloud in centered on the User and not on Projects we have a user that created some resources to centralize Projects and that is shared to everyone.

So, what we have is a calendar that was created in the Admin user (no one uses this Admin).
We have a "Generic" calendar that is shared to everyone. Than we use this calendar to put events so everyone can know whats happening but these events are only for some people to attend.

We need to have a calendar to put events about a Project so everyone knows whats happening, but these events are related to only one project so only 2 or 3 persons will be attended.

And by the logic these 2 or 3 attendees should receive a notification by email, they only receive by Nextcloud App notification.
And if i have Edit permissions on this calendar why shouldn't i have permissions to edit the Attendees?
They should receive the email notification has it is on normal calendars.

Thanks

@ChristophWurst
Copy link
Member

@nunoleite the problem is that this setup is broken. Nextcloud doesn't send out invites if you aren't the owner of the calendar. See nextcloud/server#26668.

@outofcontrol
Copy link

@ChristophWurst we have the patch in place for invites to go out which works very quite well, and our users have always managed our shared calendar. We just upgraded from v21 to v27 and find users can no longer add attenedees. I would ask that this change be reconsidered.

Ideally, and what IMO would make the calendar better, is to fix the invitation issue and not hobble the ability to maintain calendars.

I believe this change to be taking NextCloud calendar in the wrong direction.

@kesselb
Copy link
Contributor

kesselb commented Dec 5, 2023

we have the patch in place for invites to go out which works very quite well

I advise against using nextcloud/server#36756 or nextcloud/server#39702. While invitations work, it still leaves many rough edges. For example, events are shown twice sometime. The behavior for create and update events is not aligned, and weird things happen when deleting such events.

@outofcontrol
Copy link

We've been using it for I think close to 2 years, seems fine. But that is neither here nor there in regards to this change, which is removing a feature that was relied on.

@tahonermann
Copy link

I advise against using nextcloud/server#36756 or nextcloud/server#39702.

@kesselb, unfortunately, I believe Nextcloud offers no alternative at present. Per #2706, there is no ability to delegate calendar management to another user or group. Per #26668, invitations aren't sent if a non-owning user edits a shared calendar.

The removal of notifications for edits to shared calendars effectively removed the only working method for group management of a calendar. Or do you perhaps know of some other way to configure a calendar so that it can 1) be edited by multiple users, and 2) have such edits be reflected in notifications? I can't find any other documented way to accomplish this. Use of a shared account is not an attractive option for several reasons.

@nunoleite
Copy link

The lack of functionalities centered on Projects and not only on Users is a problem for project managers. And we, as a user, have to invent some workarounds. If these workarounds are being limited then the all use of Nextcloud for these things is being limited.

Note to Nextcloud development... please start thinking in implementing something for Project Management... Centered in Projects... If we (Nextcloud community) want to be a ms teams and others alternative, we have to move that way. That's what i think. We have all the projects things spread across multiple users and multiple owners. This is no good. Stop implementing new features like crazy and work on workflows... These week another extension died "Approval".
Sorry this is off-topic, but it's a problem we have when using Nextcloud since the early days.

@flortsch
Copy link

flortsch commented Dec 6, 2023

The lack of shared calendar editing functionality in NC is indeed a pain and limiting to groups of users. In our case, we use shared NC calendars in a small company of 5 people.

What works for us: we created a shared team calendar for general events, where we don't add any attendees to events and therefore don't receive any invite or change notifications / emails. NC users have to regularly look at the calendar to check if an event has been updated or some new event has been added.

For managing e.g. project appointments, the personal calendar of every NC user is shared with an "All" group (which every NC user automatically joins to using the Auto Groups app). Sharing the calendar of every NC user with this group is done through a custom database procedure that I wrote, so the NC user doesn't have to do this on his/her own, or an NC admin does not have to impersonate the user and do this through the UI. I can provide this script if interested.

In this case, every NC user can see the personal calendar of the other NC users. Now, when a NC user creates an appointment, the user creates the event in his/her own calendar, potentially adding other NC users or external people as attendees to the event. Invitation emails and event update notification emails now work because the creator/editor of the event is the owner of the event. Other NC users can then add the same event to their personal calendar.

Also, most mail/groupware/calendar clients provide a simple way to hide all calendars except the one selected, when there are too many calendar events and you quickly want to only see your appointments. In our small team, this is practicable and works well. I can also see that this could work for a few more people, and with the custom database procedure the calendar sharing can be automated so that when people join or leave the calendar is automatically shared or removed. But this would definitely become quite cumbersome and non-practical when people work in much larger / multiple / frequently changing groups, or when a NC user should manage the calendar of another NC user.

What I think is missing in NC is a group calendar feature, similar to the group-based folders app, where there is no single calendar owner and where the calendar can be managed by multiple NC users.

@ypatios
Copy link

ypatios commented Jan 2, 2024

We have also been negatively affected by this change. As a relatively large org with about 60 people, we regularly use several shared NC calendars and we are used to being able to edit the attendee list.
Please consider fixing the invitation issue instead of removing this sensible feature (sensible because if you have edit rights in a calendar you should be able to add/invite attendees).
Thanks for reading

@artforlife
Copy link

The lack of functionalities centered on Projects and not only on Users is a problem for project managers. And we, as a user, have to invent some workarounds. If these workarounds are being limited then the all use of Nextcloud for these things is being limited.

I too find the absence of this functionality highly inconvenient. I am managing a team and was sure that my assistant would be able to add people to events on a shared (mine) calendar. I was quite surprised to find out that this functionality was removed. It is quite inconvenient. We use Nextcloud because we care for our data and like the all-in-on-place approach. However, it is changes or discoveries like these that make life with Nextcloud quite frustrating. I truly hope that this gets reconsidered or fixed some other way.

@kesselb
Copy link
Contributor

kesselb commented Sep 23, 2024

#5674 (comment)

@artforlife
Copy link

#5674 (comment)

Great news, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shared calendars shouldn't allow adding attendees if the calendar is not yours
10 participants