Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump node and npm version in package.json #3223

Merged
merged 1 commit into from
Jun 16, 2021

Conversation

nickvergessen
Copy link
Member

Signed-off-by: Joas Schilling [email protected]

@codecov
Copy link

codecov bot commented Jun 16, 2021

Codecov Report

Merging #3223 (0bf0263) into master (6f76db8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3223   +/-   ##
=========================================
  Coverage     28.86%   28.86%           
  Complexity      121      121           
=========================================
  Files           157      157           
  Lines          5731     5731           
  Branches        841      841           
=========================================
  Hits           1654     1654           
  Misses         4077     4077           
Flag Coverage Δ
javascript 23.39% <ø> (ø)
php 94.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f76db8...0bf0263. Read the comment docs.

@ChristophWurst ChristophWurst merged commit e8dc2ca into master Jun 16, 2021
@delete-merged-branch delete-merged-branch bot deleted the bump-node-and-npm-version-in-package-json branch June 16, 2021 13:40
@raimund-schluessler
Copy link
Member

raimund-schluessler commented Jun 16, 2021

@ChristophWurst #3215 was not merged yet, so package-lock.json is still at version 1. I guess this will lead to problem now that npm is required to be v7 with this PR.

Surprisingly (to me at least), the build still passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants