Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve invitation update notification email #3919

Closed
st3iny opened this issue Jan 28, 2022 · 7 comments
Closed

Improve invitation update notification email #3919

st3iny opened this issue Jan 28, 2022 · 7 comments
Assignees
Labels
2. developing Work in progress enhancement New feature request Feature: Scheduling Anything around scheduling meetings, free-busy, resources, attendees and so on skill:backend Issues and PRs that require backend development skills

Comments

@st3iny
Copy link
Member

st3iny commented Jan 28, 2022

Is your feature request related to a problem? Please describe.
When responding to an invitation via an external client or my new feature, our CalDAV backend will send a notification to the organizer. However, this notification is very crude and could be improved.

Describe the solution you'd like
Show more information about what actually changed about the event. We could start by adding information about the invitee that reacted.

Describe alternatives you've considered
None

Additional context
How the notification email currently looks:
Screenshot_20220128_111203

The term "Einladung aktualisiert" means "invitation was updated" in English.

@st3iny st3iny added 1. to develop Accepted and waiting to be taken care of enhancement New feature request Feature: Scheduling Anything around scheduling meetings, free-busy, resources, attendees and so on labels Jan 28, 2022
@ChristophWurst
Copy link
Member

https://github.com/orgs/nextcloud/projects/45#card-74890297 guess this materializes that card into a ticket. Thanks :)

@tobiasKaminsky
Copy link
Member

Same happens when:

  • there is a monthly appointment
  • one appointment is moved from e.g. Wednesday to Friday
  • email is: image
  • which shows start of appointment rule, but not what appointment (today's) was changed to what (moved to Friday, different time)

@miaulalala
Copy link
Contributor

miaulalala commented Dec 12, 2022

Investigated a bit. Seems the issue is with not taking the SEQUENCE into account for recurrences.

From the iTip rfc:

  1. The primary key for referencing a particular iCalendar component
    is the "UID" property value. To reference an instance of a
    recurring component, the primary key is composed of the "UID" and
    the "RECURRENCE-ID" properties.

  2. The secondary key for referencing a component is the "SEQUENCE"
    property value. For components where the "UID" and
    "RECURRENCE-ID" property values are the same, the component with
    the highest numeric value for the "SEQUENCE" property obsoletes
    all other revisions of the component with lower values.

So when changing a single recurrence like in @tobiasKaminsky 's example, the highest SEQUENCE should win. It's not neccessary to check in out case though as the iMIP message will contain two VEVENTs, one with the RRULE, and one with the RECURRENCE-ID.

I need to check if this also works when I update the complete event with a recurrence exception.

miaulalala added a commit to nextcloud/server that referenced this issue Dec 12, 2022
instead of the main VEVENT of a repeating event

Fixes part of nextcloud/calendar#3919

Signed-off-by: Anna Larch <[email protected]>
@ChristophWurst ChristophWurst added 2. developing Work in progress and removed 1. to develop Accepted and waiting to be taken care of labels Dec 13, 2022
@ChristophWurst
Copy link
Member

Could we collect a list of use cases where we want to improve the email contents? So far we discussed

  1. Recurring events
  2. One-time event where the location (or anything similar) changed -> highlight that?
  3. ???

miaulalala added a commit to nextcloud/server that referenced this issue Jan 5, 2023
instead of the main VEVENT of a repeating event

Fixes part of nextcloud/calendar#3919

Signed-off-by: Anna Larch <[email protected]>
kesselb pushed a commit to nextcloud/server that referenced this issue Jan 24, 2023
instead of the main VEVENT of a repeating event

Fixes part of nextcloud/calendar#3919

Signed-off-by: Anna Larch <[email protected]>
kesselb pushed a commit to nextcloud/server that referenced this issue Jan 24, 2023
instead of the main VEVENT of a repeating event

Fixes part of nextcloud/calendar#3919

Signed-off-by: Anna Larch <[email protected]>
@avinash-0007
Copy link

avinash-0007 commented Jan 26, 2023

@ChristophWurst As right now ,Mail about "Invitation updated" doesn’t say what actually happened
In case of One time and Recurring event:
It would be useful to highlight
1)title
2)description
3)Location
4) Date

We can highlight the change using color change as well.For e.g
screenshot-mail google com-2023 01 26-14_28_19

@miaulalala
Copy link
Contributor

@ChristophWurst As right now ,Mail about "Invitation updated" doesn’t say what actually happened In case of One time and Recurring event: It would be useful to highlight 1)title 2)description 3)Location 4) Date

We can highlight the change using color change as well.For e.g screenshot-mail google com-2023 01 26-14_28_19

Please see nextcloud/server#35743 for the current state.

We're going to provide a diff of the changed values you mentioned above.

@ChristophWurst ChristophWurst assigned miaulalala and unassigned kesselb Jan 30, 2023
miaulalala added a commit to nextcloud/server that referenced this issue Jan 30, 2023
instead of the main VEVENT of a repeating event

Fixes part of nextcloud/calendar#3919

Signed-off-by: Anna Larch <[email protected]>
miaulalala added a commit to nextcloud/server that referenced this issue Feb 2, 2023
instead of the main VEVENT of a repeating event

Fixes part of nextcloud/calendar#3919

Signed-off-by: Anna Larch <[email protected]>
miaulalala added a commit to nextcloud/server that referenced this issue Feb 2, 2023
instead of the main VEVENT of a repeating event

Fixes part of nextcloud/calendar#3919

Signed-off-by: Anna Larch <[email protected]>
miaulalala added a commit to nextcloud/server that referenced this issue Feb 2, 2023
instead of the main VEVENT of a repeating event

Fixes part of nextcloud/calendar#3919

Signed-off-by: Anna Larch <[email protected]>
backportbot-nextcloud bot pushed a commit to nextcloud/server that referenced this issue Feb 8, 2023
instead of the main VEVENT of a repeating event

Fixes part of nextcloud/calendar#3919

Signed-off-by: Anna Larch <[email protected]>
backportbot-nextcloud bot pushed a commit to nextcloud/server that referenced this issue Feb 8, 2023
instead of the main VEVENT of a repeating event

Fixes part of nextcloud/calendar#3919

Signed-off-by: Anna Larch <[email protected]>
summersab pushed a commit to summersab/server that referenced this issue Feb 9, 2023
instead of the main VEVENT of a repeating event

Fixes part of nextcloud/calendar#3919

Signed-off-by: Anna Larch <[email protected]>
@miaulalala miaulalala moved this from 🏗️ In progress to ☑️ Done in 💌 📅 👥 Groupware team Feb 13, 2023
@miaulalala
Copy link
Contributor

Closed in nextcloud/server#35743

miaulalala added a commit to nextcloud/server that referenced this issue Mar 15, 2023
instead of the main VEVENT of a repeating event

Fixes part of nextcloud/calendar#3919

Signed-off-by: Anna Larch <[email protected]>
miaulalala added a commit to nextcloud/server that referenced this issue Mar 15, 2023
instead of the main VEVENT of a repeating event

Fixes part of nextcloud/calendar#3919

Signed-off-by: Anna Larch <[email protected]>
miaulalala added a commit to nextcloud/server that referenced this issue Jul 11, 2023
instead of the main VEVENT of a repeating event

Fixes part of nextcloud/calendar#3919

Signed-off-by: Anna Larch <[email protected]>
miaulalala added a commit to nextcloud/server that referenced this issue Jul 11, 2023
instead of the main VEVENT of a repeating event

Fixes part of nextcloud/calendar#3919

Signed-off-by: Anna Larch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress enhancement New feature request Feature: Scheduling Anything around scheduling meetings, free-busy, resources, attendees and so on skill:backend Issues and PRs that require backend development skills
Projects
Development

No branches or pull requests

7 participants