refactor(scaffolding): Migrate app template to Github template repo #1368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we just redirect the user when clicking to start an automatic download via a redirect, will it be fine? This will save us from adding caching of this, because in the current implementation, sending a download request and not caching the response will lead to a fairly simple opportunity to DDOS AppStore in some cases. |
|
You are right, the problem is that it's not simply downloading and returning the zip file, but it replaces the content in some files so the values the user submitted are applied. |
Signed-off-by: provokateurin <[email protected]>
Signed-off-by: provokateurin <[email protected]>
provokateurin
force-pushed
the
refactor/scaffolding/github-template-repo
branch
from
7f32b9f to
c39e636
Compare
for more information, see https://pre-commit.ci
Signed-off-by: Alexander Piskun <[email protected]>
bigcat88
approved these changes
Apr 29, 2024
delete-merged-branch
bot
deleted the
refactor/scaffolding/github-template-repo
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an alternative to downloading the zip on the fly the app_template repo could be added as a git submodule to pin a specific version to avoid unintended changes. This submodule would need to be updated at least once per server release which adds more work again (quite manageable though).