Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add app-template for 26 #1234

Merged
merged 4 commits into from
Dec 7, 2023
Merged

add app-template for 26 #1234

merged 4 commits into from
Dec 7, 2023

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Dec 5, 2023

#1218 went stale due to many changes ...

Let's tackle it in smaller steps ;)

  • Added a dedicated app-template for 26 instead of the symlink to 25
  • Application class is now using IBootstrap
  • nextcloud/ocp for the matching nextcloud version is installed
  • Code style applied

Base automatically changed from fix-php-cs-fixer-config to master December 5, 2023 11:51
@kesselb
Copy link
Contributor Author

kesselb commented Dec 5, 2023

@bigcat88 I still don't have a working dev setup, would you mind generating another app with this branch and sharing the result?

@bigcat88
Copy link
Member

bigcat88 commented Dec 5, 2023

app.tar.gz

@kesselb
Copy link
Contributor Author

kesselb commented Dec 7, 2023

app.tar.gz

Thank you very much 👍

  • The generated version for nextcloud/ocp seems right
  • composer install works
  • composer run cs:fix works and does not find any error (depending on the app name it may find some, but that's unavoidable)
  • npm install works
  • npm run dev works

This looks okayish to me. At least it's a bit better than before ;)

Signed-off-by: Daniel Kesselberg <[email protected]>
Signed-off-by: Daniel Kesselberg <[email protected]>
Signed-off-by: Daniel Kesselberg <[email protected]>
@kesselb kesselb force-pushed the add-template-26-ibootstrap branch from 5846e3d to 718ba93 Compare December 7, 2023 16:42
@kesselb kesselb merged commit ab26961 into master Dec 7, 2023
@kesselb kesselb deleted the add-template-26-ibootstrap branch December 7, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants