Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

certificate for user_external #208

Merged
merged 2 commits into from
Jan 2, 2019
Merged

certificate for user_external #208

merged 2 commits into from
Jan 2, 2019

Conversation

violoncelloCH
Copy link
Member

certificate for the user_external app to publish it to the appstore and make it independent from server releases
cc @nextcloud/user_external @jancborchardt
for nextcloud/user_external#22

Signed-off-by: Jonas Sulzer [email protected]

Signed-off-by: Jonas Sulzer <[email protected]>
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me 👍

@jancborchardt
Copy link
Member

@MariusBluem mentioned that the app is marked as official/shipped and should maybe have "Nextcloud" as a publisher?

@rullzer @MorrisJobke what's your call?

@rullzer
Copy link
Member

rullzer commented Dec 21, 2018

@MariusBluem mentioned that the app is marked as official/shipped and should maybe have "Nextcloud" as a publisher?

@rullzer @MorrisJobke what's your call?

Doesn't matter much IMO.

@rullzer
Copy link
Member

rullzer commented Dec 21, 2018

So. I'm a bit hessitant. In the past we have had issues with apps that were both shipped and in the appstore when upgrading.

@MariusBluem
Copy link
Member

We could remove the shipped-flag and remove it from the build script with 15.0.1. Minimal compatible version would be 15, all other old releases will not be affected.
Its not working with 15.0.0 at all in the current release so we would at least not break something ...

@violoncelloCH
Copy link
Member Author

@MariusBluem mentioned that the app is marked as official/shipped and should maybe have "Nextcloud" as a publisher?

how could I achieve this? can I just set "Nextcloud" as <author>?

I already thought I'll have to remove the shipped-flag. see PR nextcloud/user_external#26

Signed-off-by: Morris Jobke <[email protected]>
@MorrisJobke MorrisJobke merged commit 22b1e8f into master Jan 2, 2019
@MorrisJobke MorrisJobke deleted the add-user_external branch January 2, 2019 15:20
@MorrisJobke
Copy link
Member

how could I achieve this? can I just set "Nextcloud" as <author>?

That is only defined in the app store.

@violoncelloCH
Copy link
Member Author

thank you! @MorrisJobke

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants