-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
certificate for user_external #208
Conversation
Signed-off-by: Jonas Sulzer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me 👍
@MariusBluem mentioned that the app is marked as official/shipped and should maybe have "Nextcloud" as a publisher? @rullzer @MorrisJobke what's your call? |
Doesn't matter much IMO. |
So. I'm a bit hessitant. In the past we have had issues with apps that were both shipped and in the appstore when upgrading. |
We could remove the shipped-flag and remove it from the build script with 15.0.1. Minimal compatible version would be 15, all other old releases will not be affected. |
how could I achieve this? can I just set "Nextcloud" as I already thought I'll have to remove the shipped-flag. see PR nextcloud/user_external#26 |
Signed-off-by: Morris Jobke <[email protected]>
That is only defined in the app store. |
thank you! @MorrisJobke |
certificate for the user_external app to publish it to the appstore and make it independent from server releases
cc @nextcloud/user_external @jancborchardt
for nextcloud/user_external#22
Signed-off-by: Jonas Sulzer [email protected]