-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporary ignore ansible-lint var-naming[no-role-prefix] #276
Conversation
Signed-off-by: staticdev <[email protected]>
da38526
to
f0108d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
but do we need to fix it ? 😄
I suppose It will come down to ansible galaxy linter that'll impact the collection stars level
1f7413e
to
f0108d4
Compare
I am pretty sure Galaxy does not update ansible-lint as fast as we do. But yes we should fix, I can do that soon. For now it will avoid annoying emails in our inboxes. Could you approve again? I did a failed test to fix. |
Actually, It reminds me of the issues I got with pre-commit hooks: #207 that got fixed with a simple update I expect it to be disabled in a future version but for now we will deal with it with the lint ignore |
Hopefully yes or all roles using it will have to change all task names (bit big effort if you sum up for a not so big improvement). |
This error started with last update of ansible-lint. It triggers more than 80 errors. I am adding this ignore until we fix it.