Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gradient to preview images in toolbar #5634

Merged
merged 1 commit into from
Mar 12, 2020
Merged

Conversation

AndyScherzinger
Copy link
Member

Resolves #2883

Light (before) Light (after)
device-2020-03-11-184528 device-2020-03-11-184045
Dark(before) Dark(after)
device-2020-03-11-184405 device-2020-03-11-184208

Resolves #2883

Signed-off-by: Andy Scherzinger <[email protected]>
@nextcloud-android-bot
Copy link
Collaborator

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13054.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot
Copy link
Collaborator

Codacy

705

Lint

TypemasterPR
Warnings9696
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings70
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings77
Security Warnings44
Dodgy code Warnings141
Total385

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings70
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings77
Security Warnings44
Dodgy code Warnings141
Total385

@codecov
Copy link

codecov bot commented Mar 11, 2020

Codecov Report

Merging #5634 into master will decrease coverage by 0.06%.
The diff coverage is 59.45%.

@@             Coverage Diff              @@
##             master    #5634      +/-   ##
============================================
- Coverage     24.86%   24.80%   -0.07%     
  Complexity        3        3              
============================================
  Files           401      401              
  Lines         34003    34009       +6     
  Branches       4727     4728       +1     
============================================
- Hits           8456     8437      -19     
- Misses        24261    24279      +18     
- Partials       1286     1293       +7     
Impacted Files Coverage Δ Complexity Δ
...android/files/CreateFileFromTemplateOperation.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ncloud/android/files/StreamMediaFileOperation.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ava/com/owncloud/android/jobs/NotificationJob.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../operations/RichDocumentsCreateAssetOperation.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../android/operations/RichDocumentsUrlOperation.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../android/ui/activity/ConflictsResolveActivity.java 31.81% <ø> (ø) 0.00 <0.00> (ø)
...com/owncloud/android/ui/activity/FileActivity.java 29.81% <ø> (ø) 0.00 <0.00> (ø)
...cloud/android/ui/activity/FileDisplayActivity.java 25.67% <ø> (ø) 0.00 <0.00> (ø)
...roid/ui/activity/ReceiveExternalFilesActivity.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...cloud/android/ui/activity/UploadFilesActivity.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
... and 26 more

Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff, much better! :)

Probably something for a separate pull request, but is it also possible to show the fade & image below the status bar, with the status bar being transparent? From the screenshot of yours at #2485 (comment) it does seem possible, and now with the fade would also look very nice. :)

@AndyScherzinger AndyScherzinger merged commit 6df2d58 into master Mar 12, 2020
@delete-merged-branch delete-merged-branch bot deleted the previewGradient branch March 12, 2020 07:15
@AndyScherzinger
Copy link
Member Author

Probably something for a separate pull request, but is it also possible to show the fade & image below the status bar, with the status bar being transparent? From the screenshot of yours at #2485 (comment) it does seem possible, and now with the fade would also look very nice. :)

@jancborchardt yes, I guess and like you said we should then open a new issue for that The transparent system bar won't work for older Android versions but that is fine imho.

@AndyScherzinger
Copy link
Member Author

/backport to stable-3.11

@backportbot-nextcloud
Copy link

backport to stable-3.11 in #5643

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App Bar disapears in "Share Dialog"
4 participants