-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gradient to preview images in toolbar #5634
Conversation
Resolves #2883 Signed-off-by: Andy Scherzinger <[email protected]>
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13054.apk |
Codacy705Lint
SpotBugs (new)
SpotBugs (master)
|
Codecov Report
@@ Coverage Diff @@
## master #5634 +/- ##
============================================
- Coverage 24.86% 24.80% -0.07%
Complexity 3 3
============================================
Files 401 401
Lines 34003 34009 +6
Branches 4727 4728 +1
============================================
- Hits 8456 8437 -19
- Misses 24261 24279 +18
- Partials 1286 1293 +7
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff, much better! :)
Probably something for a separate pull request, but is it also possible to show the fade & image below the status bar, with the status bar being transparent? From the screenshot of yours at #2485 (comment) it does seem possible, and now with the fade would also look very nice. :)
@jancborchardt yes, I guess and like you said we should then open a new issue for that The transparent system bar won't work for older Android versions but that is fine imho. |
/backport to stable-3.11 |
backport to stable-3.11 in #5643 |
Resolves #2883