Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use correct color of account for push notification #3513

Merged
merged 1 commit into from
Jan 29, 2019
Merged

Conversation

tobiasKaminsky
Copy link
Member

Fix #3503

Signed-off-by: tobiasKaminsky [email protected]

@AndyScherzinger
Copy link
Member

AndyScherzinger commented Jan 29, 2019

👍 looks good to me code-wise

Approved with PullApprove

@nextcloud-android-bot
Copy link
Collaborator

Lint

TypemasterPR
Warnings6969
Errors00

FindBugs (new)

Warning TypeNumber
Bad practice Warnings33
Correctness Warnings156
Internationalization Warnings15
Malicious code vulnerability Warnings12
Multithreaded correctness Warnings9
Performance Warnings118
Security Warnings58
Dodgy code Warnings133
Total534

FindBugs (master)

Warning TypeNumber
Bad practice Warnings33
Correctness Warnings156
Internationalization Warnings15
Malicious code vulnerability Warnings12
Multithreaded correctness Warnings9
Performance Warnings118
Security Warnings58
Dodgy code Warnings134
Total535

@codecov
Copy link

codecov bot commented Jan 29, 2019

Codecov Report

Merging #3513 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##             master   #3513      +/-   ##
===========================================
- Coverage      6.12%   6.12%   -0.01%     
  Complexity        1       1              
===========================================
  Files           316     316              
  Lines         30723   30726       +3     
  Branches       4397    4399       +2     
===========================================
  Hits           1883    1883              
- Misses        28557   28561       +4     
+ Partials        283     282       -1
Impacted Files Coverage Δ Complexity Δ
...ava/com/owncloud/android/jobs/NotificationJob.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...wncloud/android/providers/FileContentProvider.java 15.27% <0%> (-0.02%) 0% <0%> (ø)
.../third_parties/daveKoeller/AlphanumComparator.java 82.14% <0%> (ø) 0% <0%> (ø) ⬇️

1 similar comment
@codecov
Copy link

codecov bot commented Jan 29, 2019

Codecov Report

Merging #3513 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##             master   #3513      +/-   ##
===========================================
- Coverage      6.12%   6.12%   -0.01%     
  Complexity        1       1              
===========================================
  Files           316     316              
  Lines         30723   30726       +3     
  Branches       4397    4399       +2     
===========================================
  Hits           1883    1883              
- Misses        28557   28561       +4     
+ Partials        283     282       -1
Impacted Files Coverage Δ Complexity Δ
...ava/com/owncloud/android/jobs/NotificationJob.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...wncloud/android/providers/FileContentProvider.java 15.27% <0%> (-0.02%) 0% <0%> (ø)
.../third_parties/daveKoeller/AlphanumComparator.java 82.14% <0%> (ø) 0% <0%> (ø) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants