Add DAVx5 as new app name for DAVdroid #3504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndyScherzinger
force-pushed
the
DAVx5
branch
from
8ee90bd to
c2352b0
Compare
Codecov Report
@@ Coverage Diff @@
## master #3504 +/- ##
===========================================
- Coverage 6.13% 6.13% -0.01%
Complexity 1 1
===========================================
Files 316 316
Lines 30697 30697
Branches 4392 4392
===========================================
- Hits 1884 1883 -1
Misses 28531 28531
- Partials 282 283 +1
|
src/main/res/values/strings.xml
Outdated
| @@ -49,8 +49,8 @@ | |||
| <string name="prefs_enable_media_scan_notifications_summary">Notify about newly found media folders</string> | |||
| <string name="prefs_log_delete_history_button">Delete history</string> | |||
| <string name="prefs_calendar_contacts">Sync calendar & contacts</string> | |||
| <string name="prefs_calendar_contacts_summary">Set up DAVdroid (v1.3.0+) for current account</string> | |||
| <string name="prefs_calendar_contacts_address_resolve_error">Server address for the account could not be resolved for DAVdroid</string> | |||
| <string name="prefs_calendar_contacts_summary">Set up DAVx5 (DAVdroid) (v1.3.0+) for current account</string> | |||
There was a problem hiding this comment.
Suggested change
| <string name="prefs_calendar_contacts_summary">Set up DAVx5 (DAVdroid) (v1.3.0+) for current account</string> | |
| <string name="prefs_calendar_contacts_summary">Set up DAVx5 (formerly known as DAVdroid) (v1.3.0+) for current account</string> |
Maybe?
There was a problem hiding this comment.
I did like der play store listing: https://play.google.com/store/apps/details?id=at.bitfire.davdroid&hl=en But I am fine either way. What do you thing @tobiasKaminsky ?
There was a problem hiding this comment.
Having it a bit more verbose for unknown users cannot harm :-)
tobiasKaminsky
approved these changes
Jan 28, 2019
src/main/res/values/strings.xml
Outdated
| @@ -49,8 +49,8 @@ | |||
| <string name="prefs_enable_media_scan_notifications_summary">Notify about newly found media folders</string> | |||
| <string name="prefs_log_delete_history_button">Delete history</string> | |||
| <string name="prefs_calendar_contacts">Sync calendar & contacts</string> | |||
| <string name="prefs_calendar_contacts_summary">Set up DAVdroid (v1.3.0+) for current account</string> | |||
| <string name="prefs_calendar_contacts_address_resolve_error">Server address for the account could not be resolved for DAVdroid</string> | |||
| <string name="prefs_calendar_contacts_summary">Set up DAVx5 (DAVdroid) (v1.3.0+) for current account</string> | |||
There was a problem hiding this comment.
Having it a bit more verbose for unknown users cannot harm :-)
AndyScherzinger
force-pushed
the
DAVx5
branch
from
c2352b0 to
71b1d21
Compare
|
@tobiasKaminsky @nickvergessen changed the text according to your review comment. 👍 |
|
👍 |
Signed-off-by: Andy Scherzinger <[email protected]>
Lint
FindBugs (new)
FindBugs (master)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3502
Signed-off-by: Andy Scherzinger [email protected]