Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Share link creation via bottom sheet for files in OCFileList #2747

Merged
merged 1 commit into from
Jun 28, 2018
Merged

Share link creation via bottom sheet for files in OCFileList #2747

merged 1 commit into from
Jun 28, 2018

Conversation

AndyScherzinger
Copy link
Member

see $subject, atm this is for files only, roadmap is #2485

@tobiasKaminsky tobiasKaminsky mentioned this pull request Jun 21, 2018
Open
10 tasks
@codecov
Copy link

codecov bot commented Jun 21, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@5c203f3). Click here to learn what that means.
The diff coverage is 0%.

@@           Coverage Diff            @@
##             master   #2747   +/-   ##
========================================
  Coverage          ?   6.38%           
========================================
  Files             ?     295           
  Lines             ?   29579           
  Branches          ?    4283           
========================================
  Hits              ?    1889           
  Misses            ?   27403           
  Partials          ?     287
Impacted Files Coverage Δ
...cloud/android/ui/helpers/FileOperationsHelper.java 0% <0%> (ø)
...om/owncloud/android/ui/dialog/SendShareDialog.java 0% <0%> (ø)
...cloud/android/ui/activity/FileDisplayActivity.java 0% <0%> (ø)

@tobiasKaminsky
Copy link
Member

tobiasKaminsky commented Jun 22, 2018 •
edited by AndyScherzinger
Loading

👍
Cool :-)

Approved with PullApprove

@AndyScherzinger AndyScherzinger force-pushed the bottomSheetFileShareLink branch 4 times, most recently from 4d6b7c1 to 0a50db1 Compare June 27, 2018 06:54
@nextcloud nextcloud deleted a comment Jun 27, 2018
@AndyScherzinger AndyScherzinger force-pushed the bottomSheetFileShareLink branch 2 times, most recently from 6cd1eaa to 7cec873 Compare June 27, 2018 12:40
@mario
Copy link
Contributor

mario commented Jun 28, 2018 •
edited by AndyScherzinger
Loading

👍

Approved with PullApprove

@AndyScherzinger AndyScherzinger force-pushed the bottomSheetFileShareLink branch from 7cec873 to 0745348 Compare June 28, 2018 08:44
@AndyScherzinger AndyScherzinger merged commit 1ddd0a2 into master Jun 28, 2018
@AndyScherzinger AndyScherzinger deleted the bottomSheetFileShareLink branch June 28, 2018 08:51
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.3.0 milestone Jun 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Nextcloud App 3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@AndyScherzinger @tobiasKaminsky @mario