Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iteration 4 for File detail & new sharing - email share #2700

Merged
merged 7 commits into from
Jun 14, 2018

Conversation

tobiasKaminsky
Copy link
Member

@tobiasKaminsky tobiasKaminsky commented Jun 12, 2018

This allows to enter a valid email address and then share the file/folder to it.

@codecov
Copy link

codecov bot commented Jun 12, 2018

Codecov Report

Merging #2700 into master will increase coverage by <.01%.
The diff coverage is 9.09%.

@@            Coverage Diff            @@
##           master   #2700      +/-   ##
=========================================
+ Coverage    6.52%   6.53%   +<.01%     
=========================================
  Files         285     285              
  Lines       28895   28896       +1     
  Branches     4210    4214       +4     
=========================================
+ Hits         1885    1887       +2     
  Misses      26725   26725              
+ Partials      285     284       -1
Impacted Files Coverage Δ
...ud/android/ui/fragment/util/SharingMenuHelper.java 0% <ø> (ø) ⬆️
...fragment/util/FileDetailSharingFragmentHelper.java 0% <ø> (ø) ⬆️
...in/java/com/owncloud/android/utils/ThemeUtils.java 0% <0%> (ø) ⬆️
...oid/operations/CreateShareWithShareeOperation.java 0% <0%> (ø) ⬆️
...cloud/android/ui/helpers/FileOperationsHelper.java 0% <0%> (ø) ⬆️
...ndroid/providers/UsersAndGroupsSearchProvider.java 17.02% <25%> (+0.35%) ⬆️
.../com/owncloud/android/ui/activity/Preferences.java 0% <0%> (ø) ⬆️
.../third_parties/daveKoeller/AlphanumComparator.java 82.75% <0%> (+1.14%) ⬆️

@tobiasKaminsky
Copy link
Member Author

Strange, AS should have done this automatically, but anyways thanks @AndyScherzinger

@AndyScherzinger
Copy link
Member

AndyScherzinger commented Jun 12, 2018

Strange, AS should have done this automatically, but anyways thanks @AndyScherzinger

Happy to help :)

@AndyScherzinger
Copy link
Member

AndyScherzinger commented Jun 12, 2018

👍 successfully tested, minor issues I found have been fixed along the review :)
Permissions set during creation are correct 👍

Approved with PullApprove

@AndyScherzinger AndyScherzinger changed the title Email share Iteration 4 for File detail & new sharing - email share Jun 12, 2018
@AndyScherzinger AndyScherzinger requested a review from mario June 14, 2018 12:30
@mario
Copy link
Contributor

mario commented Jun 14, 2018

👍

Approved with PullApprove

@AndyScherzinger AndyScherzinger merged commit b3d3d3c into master Jun 14, 2018
@AndyScherzinger AndyScherzinger deleted the emailShare branch June 14, 2018 21:38
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.3.0 milestone Jun 14, 2018
@AndyScherzinger
Copy link
Member

I vote for this to be backported 👍 3.2.1

@tobiasKaminsky tobiasKaminsky mentioned this pull request Jun 15, 2018
24 tasks
@Bertel3
Copy link

Bertel3 commented Jun 15, 2018

Does this solve this issue?

@AndyScherzinger
Copy link
Member

No it solves the issue of correctly set permissions for mail shares. The one you are referring to solves the creation of mail shares.

@AndyScherzinger
Copy link
Member

My mistake, misread it, yes it does

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants