Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix keyboard opening on dialogs causing squished dialogs in Material3 #10962

Merged
merged 1 commit into from
Oct 31, 2022

Conversation

AlvaroBrey
Copy link
Member

Use the proper InputMethodManager service to allow dialogs to correctly detect keyboard opening, and adjust margins properly

Fixes #10895

  • Tests written, or not not needed

Use the proper InputMethodManager service to allow dialogs to correctly detect keyboard opening, and adjust margins properly

Signed-off-by: Álvaro Brey <[email protected]>
@AlvaroBrey
Copy link
Member Author

/backport to stable-3.22

@github-actions
Copy link

Codacy

Lint

TypemasterPR
Warnings8383
Errors00

SpotBugs

CategoryBaseNew
Bad practice2828
Correctness4545
Dodgy code342342
Internationalization99
Multithreaded correctness99
Performance5858
Security2828
Total519519

@github-actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/10962.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Merging #10962 (96b12d6) into master (ef716f4) will increase coverage by 28.18%.
The diff coverage is 0.00%.

Additional details and impacted files
@@              Coverage Diff              @@
##             master   #10962       +/-   ##
=============================================
+ Coverage      3.23%   31.42%   +28.18%     
- Complexity      420     3288     +2868     
=============================================
  Files           543      544        +1     
  Lines         41001    40994        -7     
  Branches       5685     5678        -7     
=============================================
+ Hits           1327    12882    +11555     
+ Misses        39592    26202    -13390     
- Partials         82     1910     +1828     
Impacted Files Coverage Δ
...log/ChooseRichDocumentsTemplateDialogFragment.java 0.00% <0.00%> (ø)
.../android/ui/dialog/ChooseTemplateDialogFragment.kt 0.00% <0.00%> (ø)
.../android/ui/dialog/CreateFolderDialogFragment.java 0.00% <0.00%> (ø)
...loud/android/ui/dialog/MultipleAccountsDialog.java 0.00% <0.00%> (ø)
...owncloud/android/ui/dialog/NoteDialogFragment.java 0.00% <0.00%> (ø)
...ud/android/ui/dialog/RenameFileDialogFragment.java 0.00% <0.00%> (ø)
...oid/ui/dialog/RenamePublicShareDialogFragment.java 0.00% <0.00%> (ø)
...android/ui/dialog/SharePasswordDialogFragment.java 0.00% <0.00%> (ø)
...n/java/com/owncloud/android/utils/KeyboardUtils.kt 0.00% <0.00%> (ø)
.../java/com/owncloud/android/datamodel/GalleryRow.kt 50.00% <0.00%> (ø)
... and 282 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text field for new folder or renaming very narrow
1 participant