Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Assistant API #1599

Merged
merged 16 commits into from
Dec 16, 2024
Merged

Update Assistant API #1599

merged 16 commits into from
Dec 16, 2024

Conversation

alperozturk96
Copy link
Contributor

No description provided.

Copy link
Contributor

github-actions bot commented Dec 3, 2024

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

Copy link
Contributor

github-actions bot commented Dec 3, 2024

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

Copy link
Contributor

github-actions bot commented Dec 3, 2024

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

Copy link
Contributor

github-actions bot commented Dec 3, 2024

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

Copy link
Contributor

github-actions bot commented Dec 3, 2024

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

library/build.gradle Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Dec 4, 2024

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

Copy link
Contributor

github-actions bot commented Dec 4, 2024

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

@tobiasKaminsky
Copy link
Member

CI test fails due to compilation:

> Task :library:compileDebugAndroidTestKotlin FAILED
e: file:///drone/src/library/src/androidTest/java/com/owncloud/android/lib/resources/assistant/AssistantIT.kt:29:43 Unresolved reference 'types'.
e: file:///drone/src/library/src/androidTest/java/com/owncloud/android/lib/resources/assistant/AssistantIT.kt:42:53 Argument type mismatch: actual type is 'kotlin.String', but 'com.owncloud.android.lib.resources.assistant.model.TaskTypeData' was expected.

Signed-off-by: alperozturk <[email protected]>
Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

Signed-off-by: alperozturk <[email protected]>
Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

@alperozturk96 alperozturk96 marked this pull request as draft December 12, 2024 15:27
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
@nextcloud-android-bot
Copy link
Collaborator

@nextcloud-android-bot
Copy link
Collaborator

Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

Signed-off-by: alperozturk <[email protected]>
Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 50.54348% with 91 lines in your changes missing coverage. Please review.

Project coverage is 49.05%. Comparing base (6373b25) to head (74d072c).
Report is 190 commits behind head on master.

Files with missing lines Patch % Lines
...droid/lib/resources/assistant/v1/model/TaskList.kt 6.45% 29 Missing ⚠️
...droid/lib/resources/assistant/v2/model/TaskList.kt 22.72% 17 Missing ⚠️
...rces/assistant/v2/GetTaskTypesRemoteOperationV2.kt 59.45% 8 Missing and 7 partials ⚠️
...roid/lib/resources/assistant/v1/model/TaskTypes.kt 7.14% 13 Missing ⚠️
...urces/assistant/v2/GetTaskListRemoteOperationV2.kt 61.53% 8 Missing and 2 partials ⚠️
...ources/assistant/v2/DeleteTaskRemoteOperationV2.kt 70.58% 4 Missing and 1 partial ⚠️
...ources/assistant/v2/CreateTaskRemoteOperationV2.kt 87.50% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1599      +/-   ##
============================================
+ Coverage     48.90%   49.05%   +0.14%     
- Complexity     1002     1029      +27     
============================================
  Files           209      215       +6     
  Lines          7866     8087     +221     
  Branches       1021     1038      +17     
============================================
+ Hits           3847     3967     +120     
- Misses         3461     3553      +92     
- Partials        558      567       +9     
Files with missing lines Coverage Δ
...ources/assistant/v1/CreateTaskRemoteOperationV1.kt 86.66% <100.00%> (ø)
...ources/assistant/v1/DeleteTaskRemoteOperationV1.kt 70.58% <100.00%> (ø)
...urces/assistant/v1/GetTaskListRemoteOperationV1.kt 61.53% <100.00%> (ø)
...rces/assistant/v1/GetTaskTypesRemoteOperationV1.kt 61.53% <100.00%> (ø)
...roid/lib/resources/assistant/v2/model/TaskTypes.kt 100.00% <100.00%> (ø)
...ources/assistant/v2/CreateTaskRemoteOperationV2.kt 87.50% <87.50%> (ø)
...ources/assistant/v2/DeleteTaskRemoteOperationV2.kt 70.58% <70.58%> (ø)
...urces/assistant/v2/GetTaskListRemoteOperationV2.kt 61.53% <61.53%> (ø)
...roid/lib/resources/assistant/v1/model/TaskTypes.kt 7.14% <7.14%> (ø)
...rces/assistant/v2/GetTaskTypesRemoteOperationV2.kt 59.45% <59.45%> (ø)
... and 2 more

... and 23 files with indirect coverage changes

@alperozturk96 alperozturk96 marked this pull request as ready for review December 13, 2024 10:05
@tobiasKaminsky tobiasKaminsky merged commit 638326e into master Dec 16, 2024
21 checks passed
@tobiasKaminsky tobiasKaminsky deleted the update-assistant-api branch December 16, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants