Allow networks to be created pre-emptively #3129
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szaimen
requested changes
Aug 10, 2023
There was a problem hiding this comment.
Thanks for the PR, however podman should return error code 409 if the network already exists. See containers/podman#15499 and
|
This patch is needed for Nextcloud-AIO to work with Podman version 4.6.0. The most recent reply to containers/podman#15499 was 7 months ago, yet no related change has landed in Podman yet. If my setup breaks in the future, would you like me to submit another PR? |
|
Can you tell which error code is returned if the network already exists? Before the bug was fixed it was 500 if I remember correctly. Now it should in theory be 409 but apparently it is not... |
diff --git a/php/src/Docker/DockerActionManager.php b/php/src/Docker/DockerActionManager.php
index 93abcdc..a3350d6 100644
--- a/php/src/Docker/DockerActionManager.php
+++ b/php/src/Docker/DockerActionManager.php
@@ -788,7 +788,8 @@ class DockerActionManager
$responseBody = json_decode((string)$response->getBody(), true);
$connectedNetworks = $responseBody['NetworkSettings']['Networks'];
if (array_key_exists($network, $connectedNetworks)) {
- return;
+ error_log(sprintf("IAMHERE: THE ERROR IS %s", $e));
+ //return;
}
} catch (RequestException $e) {
// do nothinglogs |
|
No I meant what error code is thrown here if the network should already exist? |
|
error_log(sprintf("IAMHERE: THE ERROR IS %s", $e));The specific log line is |
|
Ah I see. However since the error code is 409, AIO should not throw, right? |
|
That is correct. Since the error code is 409, |
|
This is what I am wondering about: if the network already exists, it should return 409 and then not throw an error anymore. So why does it do on podman but not on docker? |
|
Oh, I left out some information. My bad. The error with network creation is handled correctly, however the error fails later on here: all-in-one/php/src/Docker/DockerActionManager.php Lines 785 to 803 in e8ab2c7 This is because of the linked Podman bug: containers/podman#19577 logs |
Ah I see. Since this apparently is a Podman bug, I would rather not like to merge your change into AIO as podman is not supported by us anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
nextcloud-aio-mastercontainerwill crash if thenextcloud-aionetwork already exists. This PR changes the behavior so that thenextcloud-aionetwork may be created preemptively.I did this as a workaround to a bug in rootless Podman: containers/podman#19577