-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix new event documentation #490
Conversation
adapt to current implementation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general, apart from the setObject change
This pr just reflects the code documentation: https://github.com/nextcloud/server/blob/f91a85c32eb4a4c3cef20e0daab4069437df5d07/lib/public/Activity/IManager.php#L38-L51 /**
* Generates a new IEvent object
*
* Make sure to call at least the following methods before sending it to the
* app with via the publish() method:
* - setApp()
* - setType()
* - setAffectedUser()
* - setSubject()
*
* @return IEvent
* @since 8.2.0
*/
public function generateEvent(): IEvent; So if |
Ah oh... hmm then let me fix server and you move setObject() back here |
No problem. Done. |
No description provided.