Exclude specified users from activity expiration

[akhil1508]

• On my nextcloud setup, I want to keep activities only for a few months for all users
• However, the admin activities should be there forever as they provide a great way of keeping track of admin actions and also user actions that set the activity user as admin

[artonge]

Looks good

[artonge]

Could you take a look at the CI errors?

[akhil1508]

Could you take a look at the CI errors?

@artonge Apologies, I didn't run PHP CS Fixer; should be good now

[akhil1508]

@artonge I don't understand

Error: lib/AppInfo/Application.php:114:11: TooFewArguments: Too few arguments for OCA\Activity\Data::__construct - expecting config to be passed (see https://psalm.dev/025)

As I didn't change lib/AppInfo/Application.php

[miaulalala]

@artonge I don't understand

Error: lib/AppInfo/Application.php:114:11: TooFewArguments: Too few arguments for OCA\Activity\Data::__construct - expecting config to be passed (see psalm.dev/025)

As I didn't change lib/AppInfo/Application.php

You need to register the IConfig injection to

activity/lib/AppInfo/Application.php

Lines 113 to 119 in 59e65d4

	$context->registerService(Data::class, function (ContainerInterface $c) {
	return new Data(
	$c->get(IManager::class),
	$c->get('ActivityConnectionAdapter'),
	$c->get(LoggerInterface::class),
	);
	});

		$context->registerService(Data::class, function (ContainerInterface $c) {
			return new Data(
				$c->get(IManager::class),
				$c->get('ActivityConnectionAdapter'),
				$c->get(LoggerInterface::class),
				$c->get(IConfig::class),
			);
		});

[artonge]

Could you also squash your commits into one?

[akhil1508]

Could you also squash your commits into one?

@artonge done

[miaulalala]

Tests need the new constructor properties :)

[nickvergessen]

should be only the affecteduser below.
This here would mean that actions of the given user would never expire.

Also this breaks the index usage of an already problematic query. So should only be used with care

[akhil1508]

@nickvergessen I'm confused, is the affecteduser the user for whom the activity is fired off or is the affecteduser the user the user who the activity is for?

If a user deleted an account and an activity for admins is fired, would the affecteduser row be the deleted username or the admin username? I want all the activities that are fired for admin users to not expire, to maintain a history of important activities..

[nickvergessen]

User is the actor of the action,
Affected user is the one viewing the activity stream

But then it shows a bit that the config option needs better explanation.
But I still think that only 1 of the checks should stay

[nickvergessen]

I want all the activities that are fired for admin users to not expire, to maintain a history of important activities..

Btw there is also the audit log feature in Nextcloud which is specifically designed for things like this:
https://docs.nextcloud.com/server/latest/developer_manual/basics/logging.html#admin-audit-logging

[akhil1508]

@nickvergessen But then I need to add some new code or patch the files on server as admin audit logs these user deletion and other important actions at "INFO" level.. It uses the loglevel variable and if I allow "INFO" level logs, I'm afraid performance takes a hit for my server :(

[akhil1508]

should be only the affecteduser below.

@nickvergessen Done

[nickvergessen]

https://docs.nextcloud.com/server/latest/admin_manual/configuration_server/logging_configuration.html#log-level-interaction

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

[akhil1508]

Tests need the new constructor properties :)

@miaulalala Done. I will squash again and fix commit push after final approval(s) to avoid doing it many times.

[artonge]

Still one minor lint error

[akhil1508]

Still one minor lint error

@artonge Fixed

[artonge]

@artonge Fixed

Almost :)