feat: Open previews in Viewer #1398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
force-pushed
the
feat/open-in-viewer
branch
3 times, most recently
from
80f8434 to
3dcb3d4
Compare
skjnldsv
approved these changes
Nov 9, 2023
artonge
approved these changes
Nov 9, 2023
artonge
reviewed
Nov 9, 2023
artonge
reviewed
Nov 9, 2023
Add full file path to previews so the viewer can load it Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
feat/open-in-viewer
branch
from
3dcb3d4 to
2723a25
Compare
|
Resolved the comments |
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
feat/open-in-viewer
branch
from
2723a25 to
64b5aac
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow previews / files to be opened in the viewer we need to pass the full file path in the previews. So a small API change (non breaking).
It looks like this now:
vokoscreenNG-2023-11-09_00-52-15.mp4