Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Underscore in bucket name for GCS #1289

Closed
wants to merge 1 commit into from
Closed

Conversation

cahebebe
Copy link

Accept the underscore "" character in the bucket name according to Google Cloud Storage documentation the "Bucket names can only contain lowercase letters, numeric characters, dashes (-), underscores (), and dots (.)" https://cloud.google.com/storage/docs/buckets?authuser=5&hl=en#naming

Signed-off-by: Carlos Bermúdez [email protected]

Accept the underscore "_" character in the bucket name according to Google Cloud Storage documentation the "Bucket names can only contain lowercase letters, numeric characters, dashes (-), underscores (_), and dots (.)" https://cloud.google.com/storage/docs/buckets?authuser=5&hl=en#naming

Signed-off-by: Carlos Bermúdez <[email protected]>
@ChristophWurst
Copy link
Member

This should be submit upstream in the s3 library. We don't patch our libs ususally.

@nickvergessen
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants