Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(phpunit): unify job names #300

Merged
merged 1 commit into from
Feb 6, 2024
Merged

fix(phpunit): unify job names #300

merged 1 commit into from
Feb 6, 2024

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Feb 6, 2024

To match Mariadb and Mysql formats

.github/workflow-templates/phpunit-mariadb.yml

Line 67 in 7e27df3

name: MariaDB ${{ matrix.mariadb-versions }} PHP ${{ matrix.php-versions }} Nextcloud ${{ matrix.server-versions }}

.github/workflow-templates/phpunit-mysql.yml

Line 65 in 7e27df3

name: MySQL ${{ matrix.mysql-versions }} PHP ${{ matrix.php-versions }} Nextcloud ${{ matrix.server-versions }}

@skjnldsv skjnldsv requested review from susnux and come-nc February 6, 2024 15:01
@skjnldsv skjnldsv self-assigned this Feb 6, 2024
come-nc
come-nc reviewed Feb 6, 2024
View reviewed changes
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels a bit weird that the name does not start with PHPUnit, no?
It means they won’t be close to each other in alphabetical lists also.

@skjnldsv
fix(phpunit): unify job names
475be6e 
Signed-off-by: John Molakvoæ <[email protected]>
@skjnldsv skjnldsv force-pushed the fix/unify-phpunit-job-names branch from 5fb62a4 to 475be6e Compare February 6, 2024 15:46
@come-nc come-nc merged commit b2884a9 into master Feb 6, 2024
3 checks passed
@come-nc come-nc deleted the fix/unify-phpunit-job-names branch February 6, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@come-nc come-nc come-nc approved these changes

@susnux susnux Awaiting requested review from susnux

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees

@skjnldsv skjnldsv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skjnldsv @come-nc