Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcActionRadio): follow-up fixes, promote migration to v-model #6470

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(NcActionRadio): follow-up fixes, promote migration to v-model #6470

wants to merge 1 commit into from
+16 −15

Conversation

Antreesy
Copy link
Contributor

☑️ Resolves

  • Follow-up to fix(NcActionRadio): change modelValue to behave like NcCheckboxRadioSwitch #6264
    • Revert Boolean support and default value for modelValue:
      • ⚠️ This is not suppose to work as expected
      • ⚠️ Component emitted only true before, now it's value of prop value
      • @change emit works as before
    • Add Vue warning to push developers to migrate to supported types
    • Drop second emit and ref input
    • Typo fixes

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@Antreesy Antreesy added 3. to review Waiting for reviews feature: actions Related to the actions components regression Regression of a previous working feature labels Jan 28, 2025
@Antreesy Antreesy added this to the 8.23.0 milestone Jan 28, 2025
@Antreesy Antreesy requested a review from ShGKme January 28, 2025 10:03
@Antreesy Antreesy self-assigned this Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme Awaiting requested review from ShGKme

At least 2 approving reviews are required to merge this pull request.

Assignees

@Antreesy Antreesy

Labels
3. to review Waiting for reviews feature: actions Related to the actions components regression Regression of a previous working feature
Projects
None yet
Milestone
8.23.0
Development

Successfully merging this pull request may close these issues.
1 participant
@Antreesy