feat(NcRichText): make interactive widgets opt-in #6151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hText Signed-off-by: Maksim Sukharev <[email protected]>
Antreesy
added
enhancement
8 tasks
ShGKme
changed the title
ShGKme
approved these changes
Oct 17, 2024
Comment on lines
+320
to
+321
| bottom: var(--default-grid-baseline); | ||
| right: var(--default-grid-baseline); |
There was a problem hiding this comment.
IMO, it looks better, but it can overflow the content
There was a problem hiding this comment.
We can consider:
- make a button semi-transparent when not hovered;
- make it icon button (and put text in title/aria-label
Don't see it moved outside of widget area
juliusknorr
reviewed
Oct 18, 2024
Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
Antreesy
force-pushed
the
feat/noid/reference-fixups
branch
from
afc266d to
98b4fc9
Compare
juliusknorr
approved these changes
Oct 18, 2024
|
/backport to next |
This was referenced Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖼️ Screenshots
🏚️ Before
Animotica_17_10_16_30_6.mp4
🏡 After
Animotica_17_10_16_27_43.mp4
🏁 Checklist
nextrequested with a Vue 3 upgrade